Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Iris Rev 3 QMK-DFU settings #6050

Merged
merged 2 commits into from
Jun 2, 2019
Merged

Update Iris Rev 3 QMK-DFU settings #6050

merged 2 commits into from
Jun 2, 2019

Conversation

nooges
Copy link
Member

@nooges nooges commented Jun 2, 2019

Description

Update Iris Rev 3 QMK-DFU settings with correct pinout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Jun 2, 2019

Ugh oh..... looks like there is a bug in the ENCODER support for Split Common.

Aside from that, looks good.

@drashna drashna merged commit 0744af9 into qmk:master Jun 2, 2019
@drashna
Copy link
Member

drashna commented Jun 3, 2019

@nstickney You keymap is erroring out here, because of a change to the rgb light hue range.

You don't need to change anything, but wanted to give you a heads up.

@nooges nooges deleted the fix-iris-r3-qmk-dfu branch June 3, 2019 16:27
@nstickney nstickney mentioned this pull request Jun 5, 2019
Merged
13 tasks
@nstickney
Copy link
Contributor

Thanks for the heads-up!

drashna pushed a commit that referenced this pull request Jun 6, 2019
@nstickney @drashna
[Keymap] update @nstickney's keymaps (#6076)
de29da9 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (#6050)
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@nooges @Timbus
[Keyboard] Update Iris Rev 3 QMK-DFU settings (qmk#6050)
19e2fc6 
* Set the correct pinout for Iris Rev 3 QMK-DFU

* Set bootloader to QMK-DFU
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@nstickney @Timbus
[Keymap] update @nstickney's keymaps (qmk#6076)
c7144b1 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
vostok92
vostok92 reviewed Jun 30, 2019
View reviewed changes
keyboards/keebio/iris/rules.mk
@@ -8,7 +8,7 @@ F_USB = $(F_CPU)
# different sizes, comment this out, and the correct address will be loaded
# automatically (+60). See bootloader.mk for all options.
ifeq ($(strip $(KEYBOARD)), iris/rev3)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must be:

ifeq ($(strip $(KEYBOARD)), keebio/iris/rev3)

because folder structure was changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I've submitted a fix here that makes the revision detection independent of folder structure: #6226

doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@nstickney @doughsay
[Keymap] update @nstickney's keymaps (qmk#6076)
1a0e6a2 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@nooges @drashna
[Keyboard] Update Iris Rev 3 QMK-DFU settings (qmk#6050)
f86385c 
* Set the correct pinout for Iris Rev 3 QMK-DFU

* Set bootloader to QMK-DFU
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@nstickney @drashna
[Keymap] update @nstickney's keymaps (qmk#6076)
216975d 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@nooges @JeffreyPalmer
[Keyboard] Update Iris Rev 3 QMK-DFU settings (qmk#6050)
c51cfd1 
* Set the correct pinout for Iris Rev 3 QMK-DFU

* Set bootloader to QMK-DFU
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@nstickney @JeffreyPalmer
[Keymap] update @nstickney's keymaps (qmk#6076)
f029c9e 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@nooges @swamp09
[Keyboard] Update Iris Rev 3 QMK-DFU settings (qmk#6050)
7eee72e 
* Set the correct pinout for Iris Rev 3 QMK-DFU

* Set bootloader to QMK-DFU
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@nstickney @swamp09
[Keymap] update @nstickney's keymaps (qmk#6076)
6637690 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@nstickney @drashna
[Keymap] update @nstickney's keymaps (qmk#6076)
ffee34e 
* [Keymap] iris@nstickney: improve RGB init

Perfecting the rgb backlight initialization with a delay for each
color; also start and stop the animation at the "default layer"
color.

* [Keymap] iris,ergodox@nstickney fix FN on SYMB

The function key was not operational on the SYMB and SYSH layers due
to other keycodes being mapped over MO() on those layers. The
offending keycodes have been moved to other keys.

* [Keymap] add @nstickney's userspace

Pulled common code out to a userspace directory for my iris and
ergodox keymaps.

* [Keymap] iris@nstickney add image to README

Added an image from keyboard-layout-editor.com to meet the README
standard.

* iris@nstickney hue values now `uint8_t` (qmk#6050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vostok92 vostok92 vostok92 left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nooges @drashna @nstickney @vostok92