Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xulkal user changes #6044

Merged
merged 3 commits into from
Jun 1, 2019
Merged

Xulkal user changes #6044

merged 3 commits into from
Jun 1, 2019

Conversation

XScorpion2
Copy link
Contributor

@XScorpion2 XScorpion2 commented Jun 1, 2019

Description

Created a replacement Tap Dance Double functionality saving another ~700 bytes of firmware space.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the keymap label Jun 1, 2019
@drashna drashna merged commit 4f788c2 into qmk:master Jun 1, 2019
@XScorpion2 XScorpion2 deleted the user/xulkal branch June 3, 2019 00:16
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* Xulkal user changes

Xulkal user changes

* Reduce code duplication

* Massive user code refactor
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* Xulkal user changes

Xulkal user changes

* Reduce code duplication

* Massive user code refactor
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* Xulkal user changes

Xulkal user changes

* Reduce code duplication

* Massive user code refactor
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
* Xulkal user changes

Xulkal user changes

* Reduce code duplication

* Massive user code refactor
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Xulkal user changes

Xulkal user changes

* Reduce code duplication

* Massive user code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants