Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DC01 recent build issues due to sourcing of i2c dependencies #6039

Merged
merged 1 commit into from
May 31, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 31, 2019

Description

#6038 has seen some permission errors pop out of the build.

I'm sure its due to the build system writing to a folder outside itself.

  • when docker was running as root, it could write outside the mounted folder.
  • when running outside container, it could write to a folder outside of the qmk_firmware folder

Tagging @yiancar as maintainer.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@e11i0t23
Copy link
Contributor

@yiancar Might want to see this

@yiancar
Copy link
Contributor

yiancar commented May 31, 2019

Looks good to me!

@drashna drashna merged commit dabd73b into qmk:master May 31, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
…the build to write to a folder outside of qmk_firmware (qmk#6039)
kimat pushed a commit to kimat/qmk_firmware that referenced this pull request Sep 8, 2019
…the build to write to a folder outside of qmk_firmware (qmk#6039)
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
…the build to write to a folder outside of qmk_firmware (qmk#6039)
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
…the build to write to a folder outside of qmk_firmware (qmk#6039)
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
…the build to write to a folder outside of qmk_firmware (qmk#6039)
@zvecr zvecr deleted the dc01_i2c_fix branch April 28, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants