Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Soyuz numpad #6030

Merged
merged 7 commits into from
Jun 1, 2019
Merged

Add support for Soyuz numpad #6030

merged 7 commits into from
Jun 1, 2019

Conversation

ai03-2725
Copy link
Contributor

@ai03-2725 ai03-2725 commented May 31, 2019 •
edited
Loading

Description

Adds support for the Soyuz numpad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ai03-2725 ai03-2725 changed the title Add Soyuz Numpad Add support for Soyuz numpad May 31, 2019
e11i0t23
e11i0t23 reviewed May 31, 2019
View reviewed changes
keyboards/ai03/soyuz/rules.mk Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/config.h Outdated Show resolved Hide resolved
drashna
drashna reviewed May 31, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to add community layout support?

keyboards/ai03/soyuz/soyuz.h Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/rules.mk Show resolved Hide resolved
keyboards/ai03/soyuz/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/keymaps/1U/keymap.c Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/info.json Outdated Show resolved Hide resolved
@e11i0t23 @drashna
Apply suggestions from code review
d90ba31 
Co-Authored-By: Elliot Powell <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
@drashna
Copy link
Member

drashna commented Jun 1, 2019

Awesome, thanks!

@drashna drashna merged commit 0874502 into qmk:master Jun 1, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@e11i0t23 @drashna @Timbus
[Keyboard] Add support for Soyuz numpad (qmk#6030)
059944e 
* Generate project, fill in the details

* Repair json

* Separate keymaps to numpad and all-1U

* Apply suggestions from code review

Co-Authored-By: Elliot Powell <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@e11i0t23 @drashna
[Keyboard] Add support for Soyuz numpad (qmk#6030)
777a788 
* Generate project, fill in the details

* Repair json

* Separate keymaps to numpad and all-1U

* Apply suggestions from code review

Co-Authored-By: Elliot Powell <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@e11i0t23 @drashna @JeffreyPalmer
[Keyboard] Add support for Soyuz numpad (qmk#6030)
3539803 
* Generate project, fill in the details

* Repair json

* Separate keymaps to numpad and all-1U

* Apply suggestions from code review

Co-Authored-By: Elliot Powell <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@e11i0t23 @drashna @swamp09
[Keyboard] Add support for Soyuz numpad (qmk#6030)
4efcd45 
* Generate project, fill in the details

* Repair json

* Separate keymaps to numpad and all-1U

* Apply suggestions from code review

Co-Authored-By: Elliot Powell <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e11i0t23 e11i0t23 e11i0t23 left review comments

@drashna drashna drashna approved these changes

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ai03-2725 @drashna @e11i0t23 @mechmerlin