Moving rgb typedefs into a single location #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
May 25, 2019
drashna
requested review from
drashna,
jackhumbert,
algernon,
fredizzimo,
mechmerlin,
noroadsleft,
skullydazed and
yanfali
drashna
approved these changes
May 26, 2019
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
XScorpion2
force-pushed
the
features/rgb_type_cleanup
branch
from
188cebd to
e7e4136
Compare
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 5, 2019
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 6, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Because someone named the define poorly Using full relative path as handwired/promethium has a color.h file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates RGB struct typedefs into a single location allowing us to easily change out the struct type based on the rgb driver needs.
Types of Changes
Issues Fixed or Closed by This PR
Checklist