Update hineybush keyboard projects: h87a, hineyg80 #5554

hineybush · 2019-04-04T22:56:56Z

Description

Refactor my projects into a folder (hineybush) for easier organization. Updated hineyg80 code to 1. modernize it and 2. ensure customers will have "good, working" code. I also added the JSON file for the QMK Configurator.

The h87a project now has 6.25u- and 7u-based bottom row support. Some customers were confused with which positions to use when coding. This had been reflected in the QMK Configurator JSON files.

Types of Changes

Issues Fixed or Closed by This PR

Some users had issues with the hineyg80's matrix. These have been fixed and verified working.

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add "define CONFIG_H and include "config_common.h" back to file

Add project link

Co-Authored-By: hineybush <[email protected]>

fauxpark · 2019-04-23T05:23:02Z

keyboards/hineybush/hineyg80/keymaps/default/keymap.c

+
+// Defines the keycodes used by our macros in process_record_user
+enum custom_keycodes {
+  QMKBEST = SAFE_RANGE,


Doesn't look like you're using these keycodes so this block can be removed.

keyboards/hineybush/hineyg80/config.h

keyboards/hineybush/hineyg80/rules.mk

Co-Authored-By: hineybush <[email protected]>

keyboards/hineybush/hineyg80/config.h

Co-Authored-By: hineybush <[email protected]>

* Add H87a keymap and info * Create readme.md * Add h87a .json for kbfirmware.com use * Update readme.md * Update readme.md * Update h87a files * Delete Makefile * Update readme.md * Delete desktop.ini * update files to match new QMK framework * Update files to match new QMK structure * Update files to match new QMK structure * add layout name information * Add info.json * update keymap to support layout_all * update keymap to support layout_all * update rules.mk to fix filesize * Update readme.md * Update config.h * Update readme.md * Update config.h * Update config.h Add "define CONFIG_H and include "config_common.h" back to file * update config.h to include RGB turnoff when PC goes to sleep * update info.json * update info.json * Update readme.md Add project link * Update readme.md * refactor hineybush projects into single folder. update hineyg80 to modern code * updated layout file to reflect new keymap changes * actually updated all layout names this time, verified make * Update keyboards/hineybush/h87a/h87a.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/default/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/readme.md Co-Authored-By: hineybush <[email protected]> * edit based on PR edit requests * update hiney80 files to avoid confusion * update hineyg80.h to reflect matrix * Update keyboards/hineybush/hineyg80/info.json Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/info.json Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/info.json Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/info.json Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/default/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/keymaps/wkl/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/default/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/default/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/keymaps/default/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/readme.md Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * update hineyg80 config.h * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/hineyg80.c Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/config.h Co-Authored-By: hineybush <[email protected]> * Update keyboards/hineybush/hineyg80/config.h Co-Authored-By: hineybush <[email protected]>

Josh Hinnebusch added 30 commits July 6, 2018 18:24

Add H87a keymap and info

096334d

Create readme.md

c96de1a

Add h87a .json for kbfirmware.com use

ed81ea1

Update readme.md

4275735

Update readme.md

94d2fbf

Update h87a files

7ea919f

Delete Makefile

4ae1131

Update readme.md

04530bc

Delete desktop.ini

aa6753d

update files to match new QMK framework

bc57d98

Update files to match new QMK structure

2ea995a

Update files to match new QMK structure

3229e29

add layout name information

b0981a7

Add info.json

adbd5b4

update keymap to support layout_all

c92cee4

update keymap to support layout_all

a4aa5b4

update rules.mk to fix filesize

491024e

Update readme.md

8776ed9

Update config.h

9acba6b

Update readme.md

cfb94cd

Update config.h

aefa74e

Update config.h

66e141d

Add "define CONFIG_H and include "config_common.h" back to file

update to master

11e4bd9

update config.h to include RGB turnoff when PC goes to sleep

ef431af

update info.json

238b9f5

update info.json

ad3e669

Merge branch 'master' of https://github.com/qmk/qmk_firmware

f12ff19

Merge branch 'master' of https://github.com/qmk/qmk_firmware

a828a38

Update readme.md

b957abc

Add project link

Update readme.md

6f5c5bc

fauxpark and others added 14 commits April 23, 2019 01:07

Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c

5a9ef6b

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

3b12bb5

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

f63ef77

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

8e5d5b9

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c

1d2acd1

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c

85305dd

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c

9e83c3f

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/h87a/keymaps/wkl/keymap.c

731ffc3

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

93f041b

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

f776ab7

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

718b43c

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

b67084a

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

5a8b2bb

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/hineyg80.c

0e6c4c4

Co-Authored-By: hineybush <[email protected]>

fauxpark reviewed Apr 23, 2019

View reviewed changes

drashna requested changes Apr 26, 2019

View reviewed changes

keyboards/hineybush/hineyg80/config.h Outdated Show resolved Hide resolved

keyboards/hineybush/hineyg80/config.h Outdated Show resolved Hide resolved

keyboards/hineybush/hineyg80/config.h Outdated Show resolved Hide resolved

keyboards/hineybush/hineyg80/rules.mk Show resolved Hide resolved

drashna and others added 2 commits April 26, 2019 12:42

Update keyboards/hineybush/hineyg80/config.h

e414d73

Co-Authored-By: hineybush <[email protected]>

Update keyboards/hineybush/hineyg80/config.h

317e8a5

Co-Authored-By: hineybush <[email protected]>

drashna requested changes May 1, 2019

View reviewed changes

keyboards/hineybush/hineyg80/config.h Outdated Show resolved Hide resolved

Update keyboards/hineybush/hineyg80/config.h

1856d62

Co-Authored-By: hineybush <[email protected]>

drashna approved these changes May 1, 2019

View reviewed changes

drashna removed the awaiting changes label May 1, 2019

drashna merged commit 61ce41a into qmk:master May 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update hineybush keyboard projects: h87a, hineyg80 #5554

Update hineybush keyboard projects: h87a, hineyg80 #5554

hineybush commented Apr 4, 2019 •

edited

Loading

fauxpark Apr 23, 2019

Update hineybush keyboard projects: h87a, hineyg80 #5554

Update hineybush keyboard projects: h87a, hineyg80 #5554

Conversation

hineybush commented Apr 4, 2019 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark Apr 23, 2019

Choose a reason for hiding this comment

hineybush commented Apr 4, 2019 •

edited

Loading