Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TKC1800 refactor and Configurator visual fixes #4870

Merged
merged 4 commits into from
Jan 18, 2019
Merged

TKC1800 refactor and Configurator visual fixes #4870

merged 4 commits into from
Jan 18, 2019

Conversation

noroadsleft
Copy link
Member

Commit Log

TKC1800: refactor (343fb5d)

  • tkc1800.h
    • updated to use #pragma once
    • visual alignment
  • update config.h files to use #pragma once
  • update all keymaps to use #include QMK_KEYBOARD_H
  • delete redundant mod mask, KC_TRNS, and KC_NO definitions
  • reformat keymap layers for readability
  • add block comment for Function layer in default keymap
  • delete commented action_get_macro code blocks (deprecated function)
  • update files to better conform with QMK coding conventions
  • update smt keymap to use set_single_persistent_default_layer (instead of persistent_default_layer_set)
  • replace instances of ?= with = in rules.mk

TKC1800: Configurator visual fixes (e9ad723)

  • correct key sizes and positioning
  • reformat file so each physical key object has its own line for readability
  • update and add label keys for readability

TKC1800: readme update (9906223)

  • fix image gallery link
  • update Hardware Supported and Hardware Availability lines
  • update make example (add :default suffix)
  • update QMK Docs links (Newbs Guide; grammar)

@noroadsleft
TKC1800: refactor
343fb5d 
- tkc1800.h
  - updated to use #pragma once
  - visual alignment
- update config.h files to use #pragma once
- update all keymaps to use #include QMK_KEYBOARD_H
- delete redundant mod mask, KC_TRNS, and KC_NO definitions
- reformat keymap layers for readability
- add block comment for Function layer in default keymap
- delete commented action_get_macro code blocks (deprecated function)
- update files to better conform with QMK coding conventions
- update smt keymap to use set_single_persistent_default_layer (instead of persistent_default_layer_set)
- replace instances of `?=` with `=` in rules.mk
@noroadsleft
TKC1800: Configurator visual fixes
e9ad723 
- correct key sizes and positioning
- reformat file so each physical key object has its own line for readability
- update and add `label` keys for readability
@noroadsleft
TKC1800: readme update
9906223 
- fix image gallery link
- update Hardware Supported and Hardware Availability lines
- update make example (add :default suffix)
- update QMK Docs links (Newbs Guide; grammar)
@noroadsleft
Add missing semicolons to smt keymap
5a1ba41
mechmerlin
mechmerlin approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit 12406c6 into qmk:master Jan 18, 2019
@noroadsleft noroadsleft deleted the cf/tkc1800 branch January 18, 2019 17:51
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Jan 19, 2019
Merge remote-tracking branch 'upstream/master'
a8a9bd1 
* upstream/master: (390 commits)
  [Keyboard] handwired/ortho60 Configurator update, readme update, and rules tidy (qmk#4877)
  Fix Encoder documentation (qmk#4861)
  TKC1800 refactor and Configurator visual fixes (qmk#4870)
  Fixed the build break of helix/rev1:OLED_sample caused by PR qmk#4462. (qmk#4874)
  Add cursor keys to top layer (qmk#4876)
  [Keyboard] Fix bootloader size for v60_type_r (qmk#4873)
  Flip definitions of macOS brightness alias
  Grammatical fixes for GPIO Control doc (qmk#4869)
  handwired/ortho5x13: layout macro refactor
  Add new brightness aliases to keycodes_basic.md
  [Keyboard] update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards (qmk#4612)
  Add Planck rev1 and rev2, clean up rev3-5 config.h
  Allows Terminal to use ModTap/LayerTap keys (qmk#4586)
  Defined IS_(HOST_)LED_ON/OFF() and improved LED documentation (qmk#4853)
  MacOS Brightness Alias (qmk#4836)
  [Keymap] added custom led effect keymap.c (qmk#4856)
  Simplify split_common Code significantly (qmk#4772)
  Add documentation and fix formating (qmk#4860)
  [Keymap] Adding bdk keymap for ergobox_ez (qmk#4850)
  40percent.club Luddite: Configurator update (qmk#4859)
  ...
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@noroadsleft
TKC1800 refactor and Configurator visual fixes (qmk#4870)
df894db 
* TKC1800: refactor

- tkc1800.h
  - updated to use #pragma once
  - visual alignment
- update config.h files to use #pragma once
- update all keymaps to use #include QMK_KEYBOARD_H
- delete redundant mod mask, KC_TRNS, and KC_NO definitions
- reformat keymap layers for readability
- add block comment for Function layer in default keymap
- delete commented action_get_macro code blocks (deprecated function)
- update files to better conform with QMK coding conventions
- update smt keymap to use set_single_persistent_default_layer (instead of persistent_default_layer_set)
- replace instances of `?=` with `=` in rules.mk

* TKC1800: Configurator visual fixes

- correct key sizes and positioning
- reformat file so each physical key object has its own line for readability
- update and add `label` keys for readability

* TKC1800: readme update

- fix image gallery link
- update Hardware Supported and Hardware Availability lines
- update make example (add :default suffix)
- update QMK Docs links (Newbs Guide; grammar)

* Add missing semicolons to smt keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @mechmerlin