Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Planck keymap: jcorrado #4081

Closed
wants to merge 2 commits into from
Closed

Added Planck keymap: jcorrado #4081

wants to merge 2 commits into from

Conversation

jcorrado
Copy link
Contributor

@jcorrado jcorrado commented Oct 5, 2018

PR to add my Planck keymap, which is based on the way I use the Kinesis Advantage: modifiers under thumbs, minimal contortion for modifier+layer combos, with either hand.

* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "planck.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 18-19 should be replaced with #include QMK_KEYBOARD_H.

* |--------+--------+--------+--------+--------+--------+--------+--------+--------+--------+--------+--------|
*/

[_QWERTY] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your layers should be formatted to use an appropriate LAYOUT macro, as seen here:

[_QWERTY] = LAYOUT_planck_grid(
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,
KC_ESC, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_ENT ,
BACKLIT, KC_LCTL, KC_LALT, KC_LGUI, LOWER, KC_SPC, KC_SPC, RAISE, KC_LEFT, KC_DOWN, KC_UP, KC_RGHT
),

@jcorrado
Copy link
Contributor Author

jcorrado commented Oct 5, 2018

Thanks for your help, @noroadsleft Closing this PR and submitting a new one momentarily.

@jcorrado jcorrado closed this Oct 5, 2018
@noroadsleft
Copy link
Member

You don't actually have to close PRs to make further changes.

Make the additional changes on the same branch that the PR is using as source, and push to GitHub. Your PR will update automatically.

jcorrado added a commit to jcorrado/qmk_firmware that referenced this pull request Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants