hopefully correct error in mtdjr userspace for layer_state_set_user #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, the problem was that you were excluding the "return". So ... it wasn't returning anything, and therefore erroring out. This would probably work better: uint32_t layer_state_set_user(uint32_t state) {
switch (biton32(state)) {
case _RAISE:
#ifdef RGBLIGHT_ENABLE
rgblight_sethsv_noeeprom (240, 255, 255);
#endif
break;
case _LOWER:
#ifdef RGBLIGHT_ENABLE
rgblight_sethsv_noeeprom (0, 255, 255);
#endif
break;
case _ADJUST:
#ifdef RGBLIGHT_ENABLE
rgblight_sethsv_noeeprom (0, 0, 255);
#endif
break;
default:
#ifdef RGBLIGHT_ENABLE
rgblight_sethsv_noeeprom (RGB_HUE, 255, 255);
#endif
break;
}
return state;
}As this would allow you to add other code, and still work. |
|
Awesome, thanks! |
mattfluder
pushed a commit
to mattfluder/qmk_firmware
that referenced
this pull request
Jul 30, 2018
…mk#3521) * holefully correct error in mtdjr userspace for layer_state_set_user * return state and wrap rgb actions in their own conditional
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
…mk#3521) * holefully correct error in mtdjr userspace for layer_state_set_user * return state and wrap rgb actions in their own conditional
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
…mk#3521) * holefully correct error in mtdjr userspace for layer_state_set_user * return state and wrap rgb actions in their own conditional
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
…mk#3521) * holefully correct error in mtdjr userspace for layer_state_set_user * return state and wrap rgb actions in their own conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drashna hopefully this fixes the issue in my user space for layer_state_set_user. don't really understand what's wrong.