Add LAYOUT_planck_grid to planck/dshields keymap. #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jul 25, 2018
| @@ -1,4 +1,3 @@ | |||
| #pragma message "You may need to add LAYOUT_planck_grid to your keymap layers - see default for an example" | |||
| #include "planck.h" | |||
There was a problem hiding this comment.
Could you replace these with #include QMK_KEYBOARD_H?
noroadsleft
reviewed
Jul 25, 2018
| {BL_TOGG, BL_STEP, _______, _______, _______, DM_STRT, DM_STOP, _______, _______, KC_BTN1, KC_BTN2, KC_BTN3}, | ||
| {_______, _______, _______, _______, _______, _______, _______, _______, KC_MS_L, KC_MS_D, KC_MS_U, KC_MS_R} | ||
| }, | ||
| [RSE] = LAYOUT_planck_grid( |
There was a problem hiding this comment.
I think you accidentally renamed this layer.
Was named FUN in the previous revision, and the previous layer here is already named RSE.
|
Changes made, thanks |
drashna
approved these changes
Jul 26, 2018
|
Thanks! |
mattfluder
pushed a commit
to mattfluder/qmk_firmware
that referenced
this pull request
Jul 30, 2018
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Aug 3, 2018
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Aug 5, 2018
* master: (184 commits) Docs: Clarify "right" -> "right-handed" (qmk#3507) Docs: Fixed the link to the advanced keycodes wiki (qmk#3505) Keyboard: Update KEYMAP to LAYOUT for ckeys obelus (qmk#3495) Keyboard: Hide JC65 directory in QMK Configurator (qmk#3491) Keymap: jennetters iris keymap (qmk#3488) Keymap: jennetters fourier split 40% keymap (qmk#3487) Keymap: Add LAYOUT_planck_grid to planck/dshields keymap. (qmk#3484) Keyboard: Add HelixPico keyboard (qmk#3502) Keymap: Ergodox Dvorak 42 key layout changes (qmk#3500) Keyboard: E6V2 Layout Fix (qmk#3490) Keymap: UT47:nordic - A couple of tweaks (qmk#3489) Keyboard: E6V2 LE Improvements (qmk#3486) redox: convert to use SPLIT_KEYBOARD feature (qmk#3478) Keymap: Bocaj Ergodox Updates (qmk#3364) keymap: Update khord let's split keymap and add chocopad keymap (qmk#3482) Keymap: Add smt keymap for TKC1800 (qmk#3481) Fix for the Split Common I2C code's SCL_CLOCK issue (qmk#3474) keymap: UT47:nordic - fixed typo (qmk#3477) Keyboard: Add QC60 (qmk#3472) Keyboard: Base for the nicekey keyboard (qmk#3475) ...
filoxo
pushed a commit
to filoxo/qmk_firmware
that referenced
this pull request
Aug 27, 2018
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.