add hhkb bluetooth functionality (rn42) #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pretty much straight from tmk some minor changes to make things work
This reverts commit 886713d.
|
Instead of as an option, maybe this should be a revision of the board? |
|
I'm not sure what a revision is in qmk, but I added it as an option because it is just an extra feature you might want to add to your keyboard |
|
Revisions are basically like "sub projects". They're usually used for significant design changes, so that you're not overlapping too much. The Lets Split and planck boards are examples of this. And giving the amount of changes here, I think that this may be a better idea here. @jackhumbert opinion? Or is this fine? |
|
Any word on this? |
|
Well, it doesn't touch any core files, and ... I'm more confident about merging keyboard stuff. |
|
Thanks! |
|
It seems the master branch can not be compiled with HHKB_RN42_ENABLE=yes. |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Jul 27, 2018
* add hhkb bluetooth functionality (rn42) pretty much straight from tmk some minor changes to make things work * hhkb jp personal keymap * Revert "hhkb jp personal keymap" This reverts commit 886713d.
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* add hhkb bluetooth functionality (rn42) pretty much straight from tmk some minor changes to make things work * hhkb jp personal keymap * Revert "hhkb jp personal keymap" This reverts commit 886713d.
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* add hhkb bluetooth functionality (rn42) pretty much straight from tmk some minor changes to make things work * hhkb jp personal keymap * Revert "hhkb jp personal keymap" This reverts commit 886713d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use bluetooth on your hhkb!
just do 'HHKB_RN42_ENABLE=yes' to enable