Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding kolhoz keyboard #24574

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Adding kolhoz keyboard #24574

wants to merge 18 commits into from
+273 −0

Conversation

vf1
Copy link

@vf1 vf1 commented Nov 7, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • [ x] Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Nov 7, 2024
View reviewed changes
keyboards/handwired/kolhoz/config.h Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Show resolved Hide resolved
keyboards/handwired/kolhoz/halconf.h Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/mcuconf.h Outdated Show resolved Hide resolved
@vf1 vf1 requested a review from waffle87 November 8, 2024 07:40
@waffle87 waffle87 requested a review from a team November 9, 2024 04:25
zvecr
zvecr requested changes Nov 9, 2024
View reviewed changes
keyboards/handwired/kolhoz/config.h Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@vf1 vf1 requested a review from zvecr November 9, 2024 07:48
fauxpark
fauxpark requested changes Nov 9, 2024
View reviewed changes
keyboards/handwired/kolhoz/keyboard.json Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
@vf1 vf1 requested a review from fauxpark November 9, 2024 10:18
fauxpark
fauxpark requested changes Nov 10, 2024
View reviewed changes
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
keyboards/handwired/kolhoz/keyboard.json Outdated Show resolved Hide resolved
@vf1 vf1 requested a review from fauxpark November 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie left review comments

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vf1 @fauxpark @zvecr @keyboard-magpie @waffle87