Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add bbbkeyboard/k96pro keyboard. #24132

Closed
wants to merge 2 commits into from
Closed

[Keyboard] Add bbbkeyboard/k96pro keyboard. #24132

wants to merge 2 commits into from

Conversation

jonylee1986
Copy link
Contributor

Add bbbkeyboard/k96pro keyboard.

Description

A 95% RGB keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 17, 2024
drashna
drashna reviewed Jul 18, 2024
View reviewed changes
keyboards/bbbkeyboard/k96pro/readme.md

* Keyboard Maintainer: [jonylee@hfd](https://github.com/jonylee1986)
* Hardware Supported: K96rpo
* Hardware Availability: [K96rpo](http://en.dgata.com/wproducts_content-274599.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link does not render.

@tzarc tzarc marked this pull request as draft July 20, 2024 10:44
@tzarc
Copy link
Member

tzarc commented Jul 20, 2024

On hold due to a lack of wireless code, see #24085.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna left review comments

Assignees
No one assigned
Labels
keyboard keymap needs-wireless-code via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonylee1986 @tzarc @drashna @zvecr