Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard QK65 R2 #24050

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

Siilwyn
Copy link

@Siilwyn Siilwyn commented Jul 4, 2024

Description

Add Qwertykey's keyboard the QK65 round 2.
I've based this on Owllab's fork.
The default layout is a copy of the default 65_ansi_blocker keymap with less second layer keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Notes

Succession of this previous PR: #21896
Qwertykeys shared the bootloader code with me and with the help of people on discord we figured out this custom stm32duino bootloader has a hardcoded bootloader key with not way to activate bootmagic: So I clarified this in the readme.

keyboards/qwertykeys/qk65/r2/info.json Outdated Show resolved Hide resolved
keyboards/qwertykeys/qk65/r2/qk65-r2-white.avif Outdated Show resolved Hide resolved
keyboards/qwertykeys/qk65/r2/readme.md Outdated Show resolved Hide resolved
@Siilwyn Siilwyn requested a review from waffle87 July 10, 2024 14:55
drashna
drashna previously approved these changes Jul 11, 2024
@drashna drashna dismissed their stale review July 16, 2024 02:06

tri mode wireless

@drashna
Copy link
Member

drashna commented Jul 16, 2024

This appears to be a tri mode wireless keyboard:
https://www.qwertykeys.com/products/qk65-v2

See #24085 for details on this issue.

@drashna drashna marked this pull request as draft July 16, 2024 04:17
@sigprof
Copy link
Contributor

sigprof commented Jul 16, 2024

The names of Qwertykeys boards are somewhat confusing — QK65 v2 is a different board from QK65 R2, and there were some wired-only PCB options for QK65 R2 (for some reason https://www.qwertykeys.com/products/qk65-parts-1 currently does not list the QK65 R2 ANSI Hotswap PCB which should match this firmware, but maybe they just don't have any extras available).

@Siilwyn
Copy link
Author

Siilwyn commented Jul 16, 2024

Yes sadly extras and other parts of the QK65 R2 have not been available for some time, I don't think they'll ever make any as they said it's a discontinued product, they don't work with the manufacturer anymore. But correct this is not the QK65 v2, besides qwertykeys have provided the source for this board so #24085 is not applicable here for the wired variant.
Please reconsider, I've put a lot of time in this PR and this is an old board that's not sold anymore. I understand if you want to put future qwertykeys products on hold.

@Siilwyn
Copy link
Author

Siilwyn commented Jul 23, 2024

@drashna I can adjust the readme to clarify this is about the wired QK65 R2, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants