-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Feature: Add Key Cancellation #24000
base: develop
Are you sure you want to change the base?
Conversation
cad70ca
to
bb7a856
Compare
577049a
to
28e960c
Compare
b37b2ce
to
8a05410
Compare
As long as it's not snap tap or rappy snappy. |
Some nice graphics for docs can be found here Oh wait.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some quick cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xelus22 Thanks for the PR, here is my first round of review. As the implementation is still changing I only had a look at the test cases.
6865f04
to
837ac1b
Compare
837ac1b
to
cd72383
Compare
That's phase 2 -- @Xelus22 split things up so they were easier to review. There was a WIP branch of his floating about, IIRC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed aliases to reflect the feature title - however not sure if optimal ( KC also might stand for keycode). Some thoughts from core team?
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Drashna Jaelre <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Locked as this is deviating from the intent of a PR. |
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Description
Edit: renamed to Key Cancellation
(Also open to different naming suggestions)
This adds a feature where it is a key interrupt and forces another key to be un-pressed when one key is pressed.
Usage:
keymap.c
This example shows on the first interrupt pair, when D is held, A will be interrupted and unpressed.
The second interrupt pair is when A is held, D will be unpressed.
This means that A and D can never be in the same packet (from a normal keystroke).
Types of Changes
Issues Fixed or Closed by This PR
Checklist