Fix starlight RGB animation to observe rgb on/off state & indicators #23855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3 animations named "starlight" don't initialize properly, run while RGB is disabled and do not display indicators.
Inidicator issue similar to #21792, affecting the
jellybean raindrops
animation.set_starlight_color()
function does not check an led's flags, which appears to explain why effect remains on while RGB is off.the animations also return false after updating each LED, so indicator check does not run.
Types of Changes
Checklist