Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starlight RGB animation to observe rgb on/off state & indicators #23855

Closed
wants to merge 1 commit into from

Conversation

plodah
Copy link
Contributor

@plodah plodah commented Jun 2, 2024

Description

3 animations named "starlight" don't initialize properly, run while RGB is disabled and do not display indicators.
Inidicator issue similar to #21792, affecting the jellybean raindrops animation.

set_starlight_color() function does not check an led's flags, which appears to explain why effect remains on while RGB is off.
the animations also return false after updating each LED, so indicator check does not run.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 2, 2024
@plodah plodah changed the base branch from master to develop June 2, 2024 14:38
@drashna drashna requested a review from a team June 9, 2024 01:20
@drashna
Copy link
Member

drashna commented Jun 9, 2024

Can confirm this fixes the issues with it respecting the flag settings.

@plodah plodah requested a review from drashna June 16, 2024 20:36
@plodah
Copy link
Contributor Author

plodah commented Jun 16, 2024

Sorry drashna- re-request review was a mis-click

@drashna drashna requested a review from a team June 16, 2024 20:57
Copy link

github-actions bot commented Aug 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 1, 2024
@drashna drashna added awaiting review breaking_change_2024q3 and removed stale Issues or pull requests that have become inactive without resolution. labels Aug 1, 2024
@plodah plodah closed this Aug 12, 2024
@plodah plodah deleted the starlight branch August 12, 2024 02:30
@plodah plodah restored the starlight branch August 25, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants