Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for inverted SPI CS logic #23699

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Allow for inverted SPI CS logic #23699

merged 6 commits into from
Sep 9, 2024

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented May 11, 2024 •
edited
Loading

Description

Tested on AVR and RP2040.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daskygit daskygit changed the base branch from master to develop May 11, 2024 15:44
@github-actions github-actions bot added core keyboard keymap documentation translation via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels May 11, 2024
@daskygit daskygit removed keyboard keymap documentation translation via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels May 11, 2024
sigprof
sigprof requested changes May 11, 2024
View reviewed changes
platforms/avr/drivers/spi_master.c Outdated Show resolved Hide resolved
platforms/avr/drivers/spi_master.h Outdated Show resolved Hide resolved
platforms/avr/drivers/spi_master.h Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.h Outdated Show resolved Hide resolved
@elpekenin elpekenin mentioned this pull request Jun 19, 2024
Draft
14 tasks
@daskygit daskygit requested a review from sigprof June 20, 2024 11:21
@daskygit daskygit marked this pull request as ready for review June 20, 2024 11:21
@daskygit daskygit requested a review from a team June 20, 2024 11:22
@drashna drashna requested a review from a team June 20, 2024 23:10
@tzarc tzarc added the develop-fast-track Intended to be merged early in the next develop cycle. label Aug 12, 2024
KarlK90
KarlK90 requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor and enhancement. If you could just rename the variables I'll happily approve :-)

platforms/avr/drivers/spi_master.c Outdated Show resolved Hide resolved
platforms/avr/drivers/spi_master.h Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.h Outdated Show resolved Hide resolved
@daskygit
Copy link
Member Author

daskygit commented Sep 9, 2024

I was tempted to rename a few other variables to snake_case but should probably be another PR.

@tzarc tzarc merged commit 2c7bf34 into qmk:develop Sep 9, 2024
4 checks passed
@daskygit daskygit deleted the pr/spi_cs_inversion branch September 9, 2024 23:59
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 2, 2024
@daskygit @itsme-zeix
Allow for inverted SPI CS logic (qmk#23699)
aee8025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@sigprof sigprof Awaiting requested review from sigprof

@KarlK90 KarlK90 Awaiting requested review from KarlK90

Assignees
No one assigned
Labels
core develop-fast-track Intended to be merged early in the next develop cycle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daskygit @sigprof @drashna @tzarc @KarlK90