Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YMDK YMD62 ISO PCB #23629

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add YMDK YMD62 ISO PCB #23629

merged 3 commits into from
Apr 30, 2024

Conversation

richdawe
Copy link
Contributor

@richdawe richdawe commented Apr 27, 2024 •
edited
Loading

Description

Port the YMDK YMD62 ISO PCB to QMK

I got my PCB from Mechboards in the UK: YMD62 at Mechboards UK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Apr 28, 2024
View reviewed changes
keyboards/ymdk/ymd62/chconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/halconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Show resolved Hide resolved
keyboards/ymdk/ymd62/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/mcuconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/mcuconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/rules.mk Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Apr 28, 2024
View reviewed changes
keyboards/ymdk/ymd62/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Outdated Show resolved Hide resolved
@richdawe richdawe changed the title Port YMDK YMD62 ISO PCB Add YMDK YMD62 ISO PCB Apr 28, 2024
@richdawe
Copy link
Contributor Author

Thanks @waffle87 and @zvecr for your help and feedback.

I've incorporated your suggested changes, and retested my YMD62 PCB and it works fine with the latest version.

I pushed two changes. I split out the qmk format-json into a separate change, otherwise it would have been hard to see all the other changes.

@richdawe richdawe requested review from zvecr and waffle87 April 29, 2024 08:30
@drashna drashna merged commit 4f08759 into qmk:master Apr 30, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@richdawe
Add YMDK YMD62 ISO PCB (qmk#23629)
faabfe4
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@richdawe
Add YMDK YMD62 ISO PCB (qmk#23629)
2584d1b
aaruff pushed a commit to aaruff/qmk_firmware that referenced this pull request May 22, 2024
@richdawe @aaruff
Add YMDK YMD62 ISO PCB (qmk#23629)
a54912c
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@richdawe @whoisjordangarcia
Add YMDK YMD62 ISO PCB (qmk#23629)
4b96585
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@richdawe @nuess0r
Add YMDK YMD62 ISO PCB (qmk#23629)
b6f54f3
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@richdawe @Ardakilic
Add YMDK YMD62 ISO PCB (qmk#23629)
4204dea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@waffle87 waffle87 Awaiting requested review from waffle87

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richdawe @drashna @zvecr @keyboard-magpie @waffle87