Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chew keyboard #23628

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Add Chew keyboard #23628

merged 9 commits into from
Apr 30, 2024

Conversation

flinguenheld
Copy link
Contributor

Description

Hello,
I've created a new 34 keys keyboard with a RP2040 Zéro.
You can see the repo with all information here.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Apr 27, 2024
View reviewed changes
keyboards/chew/config.h Outdated Show resolved Hide resolved
keyboards/chew/info.json Show resolved Hide resolved
keyboards/chew/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/chew/info.json Outdated Show resolved Hide resolved
keyboards/chew/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/chew/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/chew/readme.md Show resolved Hide resolved
keyboards/chew/readme.md Outdated Show resolved Hide resolved
keyboards/chew/rules.mk Outdated Show resolved Hide resolved
@flinguenheld flinguenheld requested a review from waffle87 April 27, 2024 20:43
waffle87
waffle87 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, lgtm.

keyboards/chew/info.json Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Apr 28, 2024
View reviewed changes
keyboards/chew/config.h Outdated Show resolved Hide resolved
keyboards/chew/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/chew/rules.mk Outdated Show resolved Hide resolved
keyboards/chew/info.json Outdated Show resolved Hide resolved
keyboards/chew/info.json Outdated Show resolved Hide resolved
keyboards/chew/config.h Outdated Show resolved Hide resolved
@flinguenheld flinguenheld requested a review from zvecr April 28, 2024 15:35
@drashna drashna merged commit cc35aaa into qmk:master Apr 30, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@flinguenheld
Add Chew keyboard (qmk#23628)
a3903c7
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@flinguenheld
Add Chew keyboard (qmk#23628)
67c40e1
aaruff pushed a commit to aaruff/qmk_firmware that referenced this pull request May 22, 2024
@flinguenheld @aaruff
Add Chew keyboard (qmk#23628)
9ec61e1
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@flinguenheld @whoisjordangarcia
Add Chew keyboard (qmk#23628)
478bfb8
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@flinguenheld @nuess0r
Add Chew keyboard (qmk#23628)
ce66b21
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@flinguenheld @Ardakilic
Add Chew keyboard (qmk#23628)
f70651f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flinguenheld @drashna @zvecr @waffle87