-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STK100 keyboard base on STM32WB55 #23583
Conversation
So you've chosen a wireless MCU but not implemented wireless capability? |
@tzarc As I know,BLE is not allowed by QMK because of license reason. and chibios has no BLE support to stm32wb. actually, I have implemented BLE on STM32WB + QMK,code is ugly and huge but working. ST code use some os like code, need to migrate to chibios. another issue, stm32wb is duel core , BLE stack is on M0. Any, I think it not easy. So, I would like to satisfy via requirement firstly. Do you have any suggestions? Thank |
Consider this comment an official request to provide wireless code, in order to comply with the GPL. You're more than welcome to keep your code in your fork, but as per the PR checklist QMK is not accepting non-wireless firmwares just to satisfy VIA's requirement of a keyboard in QMK Converting this to draft so an accidental merge isn't possible. |
@tzarc Thanks for your clarify. |
@tzarc Add https://github.com/JackyJia73/STM32CubeWB.git to lib. Do you think this is the right direction ? Or I need put all STM32CubeWB into kb directory. Thanks |
Neither; you need to coordinate with ChibiOS and/or ChibiOS-Contrib to work out with them the best approach — you’ll be enabling BLE support within ChibiOS first, QMK will pick it up once successfully integrated with them. |
@tzarc As STM32wb is dual core mcu,BLE stack is in cpu2. cpu1 interface with cpu2 by HCI(ipcc). All the code can be under kb directory. No need to work on Chibios. I will try work it out this way(using a few files in STM32cubeWB lib). Thanks |
The approach is interesting and definitely a good way of doing it utilizing the Mailbox approach as STM describes it. Having the second core code up in your fork will allow devs to give feedback and also clean up a bit, since as you mentioned in a prior comment it's a big repo. Lots of people might benefit from this. As tzarc mentioned tho, license following is mandatory, and must be obliged. Mixing and matching licensing gets all of us in muddy waters that no one want to be into. That's also why I suggest you put the stack on some repo of yours, that way others can poke at it and maybe give help on that and doesn't add a burden to QMK devs and maintainers. |
I'm well aware of the STM32WB model. The ST Ultimate Liberty license explicitly forbids use with the GPL, which is what your code leverages: https://github.com/JackyJia73/STM32CubeWB/blob/master/Middlewares/ST/STM32_WPAN/LICENSE.md - clause #5. You'll need to get this cleared with the ChibiOS folks as QMK is not planning on taking on bespoke integrations, bindings, nor maintenance of this. |
Add STK100 keyboard base on STM32WB55
Description
Add STK100 keyboard base on STM32WB55
Types of Changes
Issues Fixed or Closed by This PR
Checklist