Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lisa keyboard #23575

Merged
merged 21 commits into from
Apr 22, 2024
Merged

Add Lisa keyboard #23575

merged 21 commits into from
Apr 22, 2024

Conversation

key10iq
Copy link
Contributor

@key10iq key10iq commented Apr 20, 2024

Description

Lisa is a QMK and VIA compatible Tadpole mount keyboard with Prime_E layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Added new keyboard - keyten/lisa (QMK and VIA)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 20, 2024
@key10iq
Copy link
Contributor Author

key10iq commented Apr 20, 2024

I don't understand what formatting is required of me

image

@key10iq key10iq changed the title Add Lisa Add Lisa keyboard Apr 20, 2024
@sigprof
Copy link
Contributor

sigprof commented Apr 20, 2024

As usual, lint wants Unix-style line endings in all files, and you have CRLF in info.json.

@key10iq
Copy link
Contributor Author

key10iq commented Apr 20, 2024

As usual, lint wants Unix-style line endings in all files, and you have CRLF in info.json.

Spasibo, Sergey

waffle87
waffle87 requested changes Apr 20, 2024
View reviewed changes
keyboards/keyten/lisa/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keyten/lisa/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keyten/lisa/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keyten/lisa/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/keyten/lisa/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@key10iq key10iq requested a review from waffle87 April 21, 2024 00:17
@waffle87 waffle87 requested a review from a team April 21, 2024 08:36
fauxpark
fauxpark requested changes Apr 22, 2024
View reviewed changes
keyboards/keyten/lisa/lisa.c Outdated Show resolved Hide resolved
@key10iq key10iq requested a review from waffle87 April 22, 2024 04:17
@waffle87 waffle87 merged commit e807bb7 into qmk:master Apr 22, 2024
3 checks passed
@key10iq key10iq deleted the Lisa branch April 22, 2024 15:13
@key10iq key10iq mentioned this pull request Apr 23, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@key10iq @waffle87 @fauxpark
Add Lisa keyboard (qmk#23575)
862a1a0 
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@key10iq @waffle87 @fauxpark
Add Lisa keyboard (qmk#23575)
4c2d566 
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@key10iq @waffle87
@fauxpark @whoisjordangarcia
Add Lisa keyboard (qmk#23575)
772b21e 
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@key10iq @waffle87
@fauxpark @nuess0r
Add Lisa keyboard (qmk#23575)
c94d0c1 
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@key10iq @waffle87
@fauxpark @Ardakilic
Add Lisa keyboard (qmk#23575)
4f07a6c 
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@key10iq @sigprof @fauxpark @waffle87