Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up license check path. #23571

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix up license check path. #23571

merged 3 commits into from
Apr 23, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 20, 2024

Description

Running qmk license-check against any relative paths outside qmk_firmware would result in an inability to actually find the files, as the CLI cds to qmk_firmware before executing. This uses $ORIG_CWD to make the files absolute.

Had to reorder the file as qmk pytest was complaining about complexity.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 20, 2024 03:40
@github-actions github-actions bot added python cli qmk cli command labels Apr 20, 2024
@tzarc tzarc merged commit 1fa84ea into qmk:master Apr 23, 2024
4 of 5 checks passed
@tzarc tzarc deleted the cli/fixup-license-inputs branch April 23, 2024 09:38
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@tzarc
Fix up license check path. (qmk#23571)
392f7ea
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@tzarc
Fix up license check path. (qmk#23571)
4ed3463
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@tzarc @whoisjordangarcia
Fix up license check path. (qmk#23571)
d709d17
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@tzarc @nuess0r
Fix up license check path. (qmk#23571)
3f6e5e6
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@tzarc @Ardakilic
Fix up license check path. (qmk#23571)
8bd7935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @zvecr