[sofle] Fix layout order affecting messed up lower/raise/adjust layer #23555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the qwerty and colemak are at 0 and 1
waffle87
approved these changes
Apr 18, 2024
zvecr
approved these changes
Apr 19, 2024
|
Thanks @santosh , my sofle can work again! |
mzyt
pushed a commit
to mzyt/qmk_firmware
that referenced
this pull request
May 6, 2024
IvanJackson
pushed a commit
to IvanJackson/qmk_firmware
that referenced
this pull request
May 6, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At current state, flashing the default layout does not produces same results as documented in keymap.c. This happens because colemak is set to be first layout after qwerty. Every other layer is shifted by one (lower/raise/adjust).
Current behaviour is to present colemak on lower layer. Lower on raise. Raise on lower + raise. With no option to go to adjust layer.
This MR fixes it by defining lower to start on index 2 (leaving 0 & 1 for qwerty and colemak).
Types of Changes
Issues Fixed or Closed by This PR
Checklist