Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted Compensator on-state and keymaps #23509

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Adjusted Compensator on-state and keymaps #23509

merged 2 commits into from
Apr 14, 2024

Conversation

Lrfoster03
Copy link
Contributor

Description

Adjusted the on-state of the compensator caps LED to reflect what the actual values are (was misinformed about what the actual value is). Also adjusted the keymaps to include backspace instead of backslash.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adjusted caps lock on state value
  • Adjusted keymaps to include backspace (this was an oversight with the original PR)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 13, 2024
fauxpark
fauxpark requested changes Apr 13, 2024
View reviewed changes
keyboards/compensator/info.json Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team April 13, 2024 23:23
@waffle87 waffle87 merged commit 1a831a0 into qmk:master Apr 14, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@Lrfoster03
Adjusted Compensator on-state and keymaps (qmk#23509)
0ac8715
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@Lrfoster03
Adjusted Compensator on-state and keymaps (qmk#23509)
0116964
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@Lrfoster03 @whoisjordangarcia
Adjusted Compensator on-state and keymaps (qmk#23509)
ca0e3b0
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Lrfoster03 @nuess0r
Adjusted Compensator on-state and keymaps (qmk#23509)
40e9ea5
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@Lrfoster03 @Ardakilic
Adjusted Compensator on-state and keymaps (qmk#23509)
144a48c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lrfoster03 @fauxpark @waffle87