Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap PID and VID on is0gr in QMK #23458

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Swap PID and VID on is0gr in QMK #23458

merged 1 commit into from
Apr 14, 2024

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Apr 11, 2024 •
edited
Loading

Description

The PID and VID on Is0gr are swapped in the QMK repo compared to the many units that already shipped.

In order to ensure the best user experience - we'd like to standardize on the de-facto units that are out there already.

This was my mistake in changing vid/pid.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team April 11, 2024 19:18
@fauxpark fauxpark merged commit 9baafef into qmk:master Apr 14, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@awkannan
Swap PID and VID on is0gr in QMK (qmk#23458)
320c15f
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@awkannan
Swap PID and VID on is0gr in QMK (qmk#23458)
ead93e9
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@awkannan @whoisjordangarcia
Swap PID and VID on is0gr in QMK (qmk#23458)
d6910f1
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@awkannan @nuess0r
Swap PID and VID on is0gr in QMK (qmk#23458)
d1cdffc
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@awkannan @Ardakilic
Swap PID and VID on is0gr in QMK (qmk#23458)
104cd0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor approved these changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awkannan @fauxpark @waffle87 @lesshonor