Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add N8X #23444

Merged
merged 22 commits into from
Apr 11, 2024
Merged

[Keyboard] Add N8X #23444

merged 22 commits into from
Apr 11, 2024

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Apr 9, 2024

Add SIRIND & Linx3 N8X PCB

Description

TKL PCB with breakable C-type connectors in the center and between F12 and print screen.
Powered by RP2040.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@eerraa
Add N8X
ecc7601 
Add N8X
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 9, 2024
@eerraa
Change keymap.c
e38ba65 
KC_COLN to KC_SCLN
waffle87
waffle87 requested changes Apr 9, 2024
View reviewed changes
keyboards/era/linx3/n8x/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/n8x.c Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/n8x.h Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Apr 9, 2024
View reviewed changes
keyboards/era/linx3/n8x/info.json Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/readme.md Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Apr 9, 2024

Is there a missing key on top/function row (red highlighted)?
missing

dunk2k
dunk2k suggested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change LAYOUT macro name to LAYOUT_all, as per PR Checklist
  • Add "community_layouts" and their respective information in "layouts"
  • Add WKL layouts in layouts, as possible future proofing

keyboards/era/linx3/n8x/info.json Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
@eerraa
Copy link
Contributor Author

eerraa commented Apr 9, 2024 •
edited
Loading

  • Change LAYOUT macro name to LAYOUT_all, as per PR Checklist
  • Add "community_layouts" and their respective information in "layouts"
  • Add WKL layouts in layouts, as possible future proofing

thank you so much. ❤️

@eerraa eerraa closed this Apr 9, 2024
@eerraa eerraa reopened this Apr 9, 2024
@eerraa eerraa closed this Apr 9, 2024
@adophoxia
Copy link
Contributor

Stop opening and closing this PR. Doing so will make reviewing and merging this PR more difficult. It would especially be more so if you open another PR that is the exact same as this one.

@eerraa eerraa reopened this Apr 10, 2024
@eerraa
Copy link
Contributor Author

eerraa commented Apr 10, 2024

Stop opening and closing this PR. Doing so will make reviewing and merging this PR more difficult. It would especially be more so if you open another PR that is the exact same as this one.

I’m Sorry, I tried to close PR while editing the code. :(

dunk2k
dunk2k suggested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complete (community_)layouts

keyboards/era/linx3/n8x/info.json Outdated Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
keyboards/era/linx3/n8x/info.json Show resolved Hide resolved
eerraa and others added 7 commits April 10, 2024 16:42
@eerraa @dunk2k
Update keyboards/era/linx3/n8x/info.json
6720abe 
Co-authored-by: Duncan Sutherland <[email protected]>
@eerraa @dunk2k
Update keyboards/era/linx3/n8x/info.json
6b9e625 
Co-authored-by: Duncan Sutherland <[email protected]>
@eerraa @dunk2k
Update keyboards/era/linx3/n8x/info.json
2cfa050 
Co-authored-by: Duncan Sutherland <[email protected]>
@eerraa @dunk2k
Update keyboards/era/linx3/n8x/info.json
7c1dad8 
Co-authored-by: Duncan Sutherland <[email protected]>
@eerraa
Modified layout
41e40e5 
Modified layout
@eerraa
Removed code related to VIA
776e944 
Removed code related to VIA
@eerraa
Remove keyboard.c and keyboard.h
c0d35ff 
Remove keyboard.c and keyboard.h
@waffle87 waffle87 merged commit de4d28c into qmk:master Apr 11, 2024
3 checks passed
@eerraa eerraa mentioned this pull request Apr 11, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@eerraa @waffle87 @dunk2k
[Keyboard] Add N8X (qmk#23444)
bea1350 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@eerraa @waffle87 @dunk2k
[Keyboard] Add N8X (qmk#23444)
d21e58f 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@eerraa @waffle87
@dunk2k @whoisjordangarcia
[Keyboard] Add N8X (qmk#23444)
06eebd8 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@eerraa @waffle87
@dunk2k @nuess0r
[Keyboard] Add N8X (qmk#23444)
594c3e2 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@eerraa @waffle87
@dunk2k @Ardakilic
[Keyboard] Add N8X (qmk#23444)
5150f35 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adophoxia adophoxia adophoxia left review comments

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eerraa @dunk2k @adophoxia @fauxpark @waffle87