Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds keyboard suikagiken_suika85ergo #23380

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Adds keyboard suikagiken_suika85ergo #23380

merged 6 commits into from
Apr 17, 2024

Conversation

suikagiken
Copy link
Contributor

Description

Adds suikagiken suika85ergo as a new keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Mar 31, 2024
View reviewed changes
keyboards/suikagiken/config.h Outdated Show resolved Hide resolved
keyboards/suikagiken/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/suikagiken/info.json Outdated Show resolved Hide resolved
keyboards/suikagiken/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/suikagiken/keymaps/default/keymap.c Outdated Show resolved Hide resolved
lesshonor
lesshonor suggested changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder structure is not quite right according to the README. Please create the suika85ergo folder underneath suikagiken, and move all the keyboard files into it.

@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Apr 1, 2024
@suikagiken
Copy link
Contributor Author

@waffle87 @lesshonor
Thank you for your suggestion. I have made the changes and committed them, please check back.

waffle87
waffle87 requested changes Apr 4, 2024
View reviewed changes
keyboards/suikagiken/suika85ergo/info.json Outdated Show resolved Hide resolved
keyboards/suikagiken/suika85ergo/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/suikagiken/suika85ergo/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/suikagiken/suika85ergo/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@suikagiken
Copy link
Contributor Author

As pointed out, Elite-C is used. I've also fixed the other points, thank you.

@suikagiken suikagiken requested a review from waffle87 April 5, 2024 06:49
@waffle87 waffle87 requested review from a team and removed request for lesshonor April 5, 2024 14:42
@waffle87 waffle87 merged commit c25dfe5 into qmk:master Apr 17, 2024
3 checks passed
@suikagiken suikagiken deleted the suika85ergo branch April 17, 2024 15:01
@suikagiken suikagiken mentioned this pull request Apr 17, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@suikagiken
[Keyboard] Add suika85ergo (qmk#23380)
177fdd2
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@suikagiken
[Keyboard] Add suika85ergo (qmk#23380)
1c0cfd3
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@suikagiken @whoisjordangarcia
[Keyboard] Add suika85ergo (qmk#23380)
7accf5c
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@suikagiken @nuess0r
[Keyboard] Add suika85ergo (qmk#23380)
096b42b
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@suikagiken @Ardakilic
[Keyboard] Add suika85ergo (qmk#23380)
605d7d5
@suikagiken suikagiken restored the suika85ergo branch November 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor approved these changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suikagiken @fauxpark @waffle87 @lesshonor