Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skiller_skg50_s2 keyboard #23364

Merged
merged 14 commits into from
Mar 31, 2024
Merged

Added skiller_skg50_s2 keyboard #23364

merged 14 commits into from
Mar 31, 2024

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Mar 27, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 27, 2024
@itarze @dunk2k
更新 info.json
760d824 
Co-authored-by: Duncan Sutherland <[email protected]>
@dunk2k
Copy link
Contributor

dunk2k commented Mar 27, 2024 •
edited
Loading

Does this PCB have ISO (form factor) support?

in particular - ISO Hash and ISO Enter keys

dunk2k
dunk2k suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Community Layout support

keyboards/sharkoon/skiller_sgk50_s2/info.json Show resolved Hide resolved
keyboards/sharkoon/skiller_sgk50_s2/info.json Show resolved Hide resolved
itarze and others added 2 commits March 27, 2024 20:07
@itarze @dunk2k
更新 info.json
a242133 
Co-authored-by: Duncan Sutherland <[email protected]>
@itarze @dunk2k
更新 info.json
d1ea99d 
Co-authored-by: Duncan Sutherland <[email protected]>
@itarze
Copy link
Contributor Author

itarze commented Mar 27, 2024

Does this PCB have ISO (form factor) support?

in particular - ISO Hash and ISO Enter keys

yes.

@dunk2k
Copy link
Contributor

dunk2k commented Mar 27, 2024

Does this PCB have ISO (form factor) support?
in particular - ISO Hash and ISO Enter keys

yes.

Great stuff.
Would I be correct that the matrix co-ordinates for the following keys are identical?:

  • ANSI Backslash <> ISO Hash
  • ANSI Enter <> ISO Enter

dunk2k
dunk2k suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conforms to PR Checklist regarding a PCB with multiple layouts

keyboards/sharkoon/skiller_sgk50_s2/info.json Outdated Show resolved Hide resolved
keyboards/sharkoon/skiller_sgk50_s2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/sharkoon/skiller_sgk50_s2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@itarze
Copy link
Contributor Author

itarze commented Mar 27, 2024

Does this PCB have ISO (form factor) support?

in particular - ISO Hash and ISO Enter keys

yes.

Great stuff.

Would I be correct that the matrix co-ordinates for the following keys are identical?:

  • ANSI Backslash <> ISO Hash

  • ANSI Enter <> ISO Enter

bingo.

itarze and others added 3 commits March 27, 2024 20:24
@itarze @dunk2k
更新 info.json
10c82b0 
Co-authored-by: Duncan Sutherland <[email protected]>
@itarze @dunk2k
更新 keymap.c
450d5ff 
Co-authored-by: Duncan Sutherland <[email protected]>
@itarze @dunk2k
更新 keymap.c
965eb9c 
Co-authored-by: Duncan Sutherland <[email protected]>
dunk2k
dunk2k suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Community Layout support: 96_iso

keyboards/sharkoon/skiller_sgk50_s2/info.json Outdated Show resolved Hide resolved
keyboards/sharkoon/skiller_sgk50_s2/info.json Show resolved Hide resolved
itarze and others added 2 commits March 27, 2024 20:28
@itarze @dunk2k
更新 info.json
a3bef00 
Co-authored-by: Duncan Sutherland <[email protected]>
@itarze @dunk2k
更新 info.json
f7a3bba 
Co-authored-by: Duncan Sutherland <[email protected]>
@dunk2k
Copy link
Contributor

dunk2k commented Mar 27, 2024

Would I be correct that the matrix co-ordinates for the following keys are identical?:

  • ANSI Backslash <> ISO Hash
  • ANSI Enter <> ISO Enter

bingo.

Thanks for confirming, code suggestion added 🙂

dunk2k
dunk2k suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add EoF

keyboards/sharkoon/skiller_sgk50_s2/info.json Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 29, 2024 06:52
@waffle87 waffle87 merged commit e9f187f into qmk:master Mar 31, 2024
3 checks passed
@itarze itarze mentioned this pull request Mar 31, 2024
Merged
7 tasks
@itarze itarze deleted the skiller_skg50_s2 branch March 31, 2024 01:38
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@itarze @dunk2k @waffle87
[Keyboard] Add skiller_skg50_s2 (qmk#23364)
bdd5730 
Co-authored-by: wb <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@itarze @dunk2k
@waffle87 @girtsf
[Keyboard] Add skiller_skg50_s2 (qmk#23364)
8a0d605 
Co-authored-by: wb <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@itarze @dunk2k
@waffle87 @whoisjordangarcia
[Keyboard] Add skiller_skg50_s2 (qmk#23364)
b96a468 
Co-authored-by: wb <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@itarze @dunk2k
@waffle87 @nuess0r
[Keyboard] Add skiller_skg50_s2 (qmk#23364)
95d3022 
Co-authored-by: wb <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itarze @dunk2k @drashna @waffle87