Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'qmk compile' mass_compile execution #23296

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Fix 'qmk compile' mass_compile execution #23296

merged 1 commit into from
Mar 31, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 16, 2024

Description

$ cd keyboards/lets_split
$ qmk compile -km all
Ψ Retrieving list of keymaps for keyboard "None"...
<class 'ValueError'>

and

$ qmk compile -kb lets_split -km all
Ψ Retrieving list of keymaps for keyboard "lets_split/rev2"...
Ψ Preparing target list...
<class 'KeyError'>
☒ 'no_temp'
Traceback (most recent call last):
  File "/home/zvecr/qmk_firmware_clean/.direnv/python-3.11/lib/python3.11/site-packages/milc/milc.py", line 604, in __call__
    return self.__call__()
           ^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/.direnv/python-3.11/lib/python3.11/site-packages/milc/milc.py", line 609, in __call__
    return self._subcommand(self)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/lib/python/qmk/decorators.py", line 27, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/lib/python/qmk/decorators.py", line 47, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/lib/python/qmk/cli/compile.py", line 56, in compile
    return mass_compile(cli)
           ^^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/lib/python/qmk/cli/mass_compile.py", line 111, in mass_compile
    return mass_compile_targets(targets, cli.args.clean, cli.args.dry_run, cli.args.no_temp, cli.config.mass_compile.parallel, **build_environment(cli.args.env))
                                                                           ^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/.direnv/python-3.11/lib/python3.11/site-packages/milc/attrdict.py", line 32, in __getattr__
    return self.__getitem__(key)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/zvecr/qmk_firmware_clean/.direnv/python-3.11/lib/python3.11/site-packages/milc/attrdict.py", line 37, in __getitem__
    return self._data[key]
           ~~~~~~~~~~^^^^^
KeyError: 'no_temp

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Mar 16, 2024
@zvecr zvecr added the bug label Mar 16, 2024
@zvecr zvecr merged commit 319d9aa into master Mar 31, 2024
4 of 5 checks passed
@zvecr zvecr deleted the cli_compile_fixes branch March 31, 2024 11:23
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants