Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First support for Minerva LX #23291

Merged
merged 9 commits into from
Mar 29, 2024
Merged

First support for Minerva LX #23291

merged 9 commits into from
Mar 29, 2024

Conversation

archetype-made
Copy link
Contributor

Description

Adds support for Minerva LX by Archetype.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 15, 2024
@archetype-made archetype-made marked this pull request as ready for review March 15, 2024 18:52
waffle87
waffle87 requested changes Mar 15, 2024
View reviewed changes
keyboards/archetype/minervalx/config.h Outdated Show resolved Hide resolved
keyboards/archetype/minervalx/info.json Outdated Show resolved Hide resolved
keyboards/archetype/minervalx/readme.md Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team March 15, 2024 20:02
fauxpark
fauxpark requested changes Mar 22, 2024
View reviewed changes
keyboards/archetype/minervalx/info.json Show resolved Hide resolved
keyboards/archetype/minervalx/readme.md Outdated Show resolved Hide resolved
@archetype-made
Update info.json
e9b5936 
Update info.json - update maintainer
@drashna drashna merged commit 742ff91 into qmk:master Mar 29, 2024
2 checks passed
@archetype-made archetype-made mentioned this pull request Apr 4, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@archetype-made @waffle87
@Gondolindrim @zvecr @fauxpark
[Keyboard] Add Minerva LX (qmk#23291)
8a33772 
Co-authored-by: jack <[email protected]>
Co-authored-by: Álvaro A. Volpato <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@archetype-made @waffle87
@Gondolindrim @zvecr @fauxpark @girtsf
[Keyboard] Add Minerva LX (qmk#23291)
120f60f 
Co-authored-by: jack <[email protected]>
Co-authored-by: Álvaro A. Volpato <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@archetype-made @waffle87
@Gondolindrim @zvecr @fauxpark @whoisjordangarcia
[Keyboard] Add Minerva LX (qmk#23291)
bcfbc71 
Co-authored-by: jack <[email protected]>
Co-authored-by: Álvaro A. Volpato <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@archetype-made @waffle87
@Gondolindrim @zvecr @fauxpark @nuess0r
[Keyboard] Add Minerva LX (qmk#23291)
56b518a 
Co-authored-by: jack <[email protected]>
Co-authored-by: Álvaro A. Volpato <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gondolindrim Gondolindrim Gondolindrim left review comments

@zvecr zvecr zvecr requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@archetype-made @drashna @fauxpark @zvecr @Gondolindrim @waffle87