Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IGNORE_MOD_TAP_INTERRUPT from keymaps #23279

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 14, 2024

Description

Only 2 references remain,

  • keyboards/marksard/leftover30/keymaps/default_isoenter/config.h
    • marksard/leftover30:default_isoenter fails in CI runs (23277)
  • keyboards/hazel/bad_wings/keymaps/jasonhazel/config.h
    • deemed to be a user keymap so just removed

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 14, 2024
@drashna drashna merged commit 5ef5a79 into master Mar 29, 2024
3 checks passed
@drashna drashna deleted the ignore_mod_tap_interrupt_km branch March 29, 2024 04:55
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants