Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Add Macropad 15Pad ] #23257

Merged
merged 20 commits into from
Mar 29, 2024
Merged

[ Add Macropad 15Pad ] #23257

merged 20 commits into from
Mar 29, 2024

Conversation

veriyaniot
Copy link
Contributor

@veriyaniot veriyaniot commented Mar 11, 2024 •
edited
Loading

Description

[ Add Macropad 15Pad ]

Thanks to zlabkeeb for trusting me to work on this project

  • RP2040 Zero
  • Hotswap Kailh
  • 12 Switch
  • 3 Rotary Knob

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 11, 2024
@veriyaniot veriyaniot requested a review from drashna March 15, 2024 05:44
lesshonor
lesshonor suggested changes Mar 17, 2024
View reviewed changes
keyboards/zlabkeeb/15pad/rules.mk Outdated Show resolved Hide resolved
keyboards/zlabkeeb/15pad/info.json Outdated Show resolved Hide resolved
keyboards/zlabkeeb/15pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/zlabkeeb/15pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/zlabkeeb/15pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/zlabkeeb/15pad/keymaps/via/keymap.c Show resolved Hide resolved
@veriyaniot veriyaniot requested a review from lesshonor March 17, 2024 05:43
@veriyaniot veriyaniot requested a review from waffle87 March 20, 2024 15:00
@waffle87 waffle87 requested review from a team and removed request for lesshonor March 20, 2024 15:10
@veriyaniot veriyaniot requested a review from zvecr March 21, 2024 06:47
@veriyaniot
Copy link
Contributor Author

what else needs to be improved??
I'm very enthusiastic 😅

@drashna drashna merged commit afafce0 into qmk:master Mar 29, 2024
3 checks passed
@veriyaniot
Copy link
Contributor Author

Thanks @drashna

@veriyaniot veriyaniot mentioned this pull request Mar 29, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@veriyaniot @lesshonor
@waffle87 @zvecr
[Keyboard] Add Macropad 15Pad (qmk#23257)
02d11f2 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@veriyaniot @lesshonor
@waffle87 @zvecr @girtsf
[Keyboard] Add Macropad 15Pad (qmk#23257)
2734972 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@veriyaniot @lesshonor
@waffle87 @zvecr @whoisjordangarcia
[Keyboard] Add Macropad 15Pad (qmk#23257)
4a82501 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@veriyaniot @lesshonor
@waffle87 @zvecr @nuess0r
[Keyboard] Add Macropad 15Pad (qmk#23257)
2d95a5b 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@veriyaniot @drashna @zvecr @waffle87 @lesshonor