-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds rot13labs hackboard #23218
adds rot13labs hackboard #23218
Conversation
Co-authored-by: Duncan Sutherland <[email protected]>
removing enables from rules to move into info.json features
adds features from rules.mk
removes community layout as the hackboard does not support the tkl_ansi community layout
@dunk2k yeah, the button itself is very unique and im basically just hijacking an open spot in the grid so the button can be programmed via QMK as if it was a switch. I designed the hardware before I fully understood QMK so its not ideal, but it still works very well for my needs. TL:DR; functionally the layout you posted is correct, even though visually the keyboard appears to match the standard community layout. |
Thanks for explaining, it's that extra button is what was putting the community layout awry. Would the unique button be better placed a row, of sorts, above the Function row? |
Oh, yeah as long as its just for visuals sake I think that would be great! How/where can I do that so it wont affect the functionality? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conforms to PR Checklist regarding physical layout(s)
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
updates the layout to more closely match the hackboard
updates the keymap to match the new layout
Sweet! Thanks! Thats been updated now. |
@c0ldbru |
nah, its to the left of the boot and reset buttons; above F4/F5 |
@dunk2k Just checking in to make sure theres nothing waiting on me for this? Let me know if theres anything I missed! |
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
@drashna Any chance you can review this? I believe your approval is all its waiting on. |
@c0ldbru, unfortunately I'm not a QMK maintainer, thus I'm unable to merge PRs. Could I suggest on the qmk_firmware channel of the QMK Discord, relay this PR's number and ask if it could be given a look over 🙂 |
Co-authored-by: c0ldbru <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: c0ldbru <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: c0ldbru <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: c0ldbru <[email protected]> Co-authored-by: Duncan Sutherland <[email protected]>
Description
Adds rot13labs hackboard as a new keyboard
Types of Changes
Issues Fixed or Closed by This PR
Checklist