Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 60XT #23210

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Add 60XT #23210

merged 5 commits into from
Mar 8, 2024

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Mar 4, 2024

Description

Addition of 60XT PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 4, 2024
waffle87
waffle87 requested changes Mar 4, 2024
View reviewed changes
keyboards/cipulot/60xt/info.json Show resolved Hide resolved
keyboards/cipulot/60xt/info.json Outdated Show resolved Hide resolved
keyboards/cipulot/60xt/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cipulot/60xt/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@Cipulot
Copy link
Contributor Author

Cipulot commented Mar 4, 2024

Changes applied. Overlooked the LAYOUT_all usage instead of the LAYOUT in the review I did before the PR, my bad 😅

@waffle87 waffle87 requested a review from a team March 4, 2024 19:11
@drashna drashna merged commit 30b0600 into qmk:master Mar 8, 2024
3 checks passed
This was referenced Mar 8, 2024
Merged
Merged
vpadillap pushed a commit to vpadillap/qmk_firmware that referenced this pull request Mar 11, 2024
@Cipulot @waffle87 @vpadillap
[Keyboard] Add 60XT (qmk#23210)
3107459 
Co-authored-by: jack <[email protected]>
@Cipulot Cipulot deleted the add_60xt branch April 1, 2024 22:03
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@Cipulot @waffle87 @whoisjordangarcia
[Keyboard] Add 60XT (qmk#23210)
8df1ed9 
Co-authored-by: jack <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Cipulot @waffle87 @nuess0r
[Keyboard] Add 60XT (qmk#23210)
98407b8 
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cipulot @drashna @waffle87