Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix changed files on CI workflow #23205

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Attempt to fix changed files on CI workflow #23205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0538d67
Update lint.yml
zvecr Mar 3, 2024
81ca994
Update format.yml
zvecr Mar 3, 2024
7ab3a21
Skip files that do not exist?
zvecr Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
- name: Get changed files
id: file_changes
uses: tj-actions/changed-files@v42
with:
use_rest_api: true

- name: Run qmk formatters
shell: 'bash {0}'
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:
- name: Get changed files
id: file_changes
uses: tj-actions/changed-files@v42
with:
use_rest_api: true

- name: Print info
run: |
Expand Down Expand Up @@ -62,10 +64,12 @@ jobs:

qmk format-text ${{ steps.file_changes.outputs.all_changed_files}} || true
for file in ${{ steps.file_changes.outputs.all_changed_files}}; do
if ! git diff --quiet $file; then
echo "File '${file}' Requires Formatting"
echo "::error file=${file}::Requires Formatting"
exit_code=$(($exit_code + 1))
if [[ -f $file ]]; then
if ! git diff --quiet $file; then
echo "File '${file}' Requires Formatting"
echo "::error file=${file}::Requires Formatting"
exit_code=$(($exit_code + 1))
fi
fi
done

Expand Down
Loading