Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keyboard "Ejectix" #23204

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Add new keyboard "Ejectix" #23204

merged 9 commits into from
Mar 8, 2024

Conversation

takashicompany
Copy link
Contributor

@takashicompany takashicompany commented Mar 3, 2024 •
edited
Loading

Description

I have designed a new keyboard and firmware and would appreciate a pull request review.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 3, 2024
waffle87
waffle87 requested changes Mar 3, 2024
View reviewed changes
keyboards/takashicompany/ejectix/info.json Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/info.json Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/readme.md Outdated Show resolved Hide resolved
takashicompany and others added 7 commits March 5, 2024 01:20
@waffle87 waffle87 requested a review from a team March 4, 2024 16:58
dunk2k
dunk2k suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add EoF where non-present

keyboards/takashicompany/ejectix/info.json Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/takashicompany/ejectix/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@drashna @dunk2k
Fix end of file changes
5ed98fa 
Co-authored-by: Duncan Sutherland <[email protected]>
@drashna drashna merged commit 0a03fc5 into qmk:master Mar 8, 2024
3 checks passed
vpadillap pushed a commit to vpadillap/qmk_firmware that referenced this pull request Mar 11, 2024
@takashicompany @waffle87
@dunk2k @drashna @vpadillap
[Keyboard] Add Ejectix (qmk#23204)
972b0d7 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@takashicompany @waffle87
@dunk2k @drashna @whoisjordangarcia
[Keyboard] Add Ejectix (qmk#23204)
16294e2 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@takashicompany @waffle87
@dunk2k @drashna @nuess0r
[Keyboard] Add Ejectix (qmk#23204)
50eea51 
Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takashicompany @drashna @waffle87 @dunk2k