Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PetruziaMini Handwired Keyboard #23201

Merged
merged 14 commits into from
Mar 12, 2024
Merged

Add the PetruziaMini Handwired Keyboard #23201

merged 14 commits into from
Mar 12, 2024

Conversation

LLLKST
Copy link
Contributor

@LLLKST LLLKST commented Mar 3, 2024

Description

First time trying to upload something to github.
The PetruziaMini is my first hand-wired mechanical kb and due to my lack of experience in programming I would like to know if I can, after the approval of the request, create my own firmware using the qmk configurator. The first part I did should be ok, if my calculations are correct and I can do the next step on the configurator I would fly very high. I don't really know anything about github, if it really works like I think I'll make an effort to curate my own keyboard pages. Thanks for everything.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

LLLKST added 2 commits March 2, 2024 22:52
My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now
keyboards/handwired/petruziamini/config.h Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/readme.md Show resolved Hide resolved
keyboards/handwired/petruziamini/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/info.json Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/info.json Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/info.json Outdated Show resolved Hide resolved
I compiled it locally and works
@LLLKST LLLKST requested review from zvecr and waffle87 March 3, 2024 08:26
keyboards/handwired/petruziamini/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/petruziamini/readme.md Outdated Show resolved Hide resolved
Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste
LLLKST added 2 commits March 3, 2024 19:05
Thanks for helping! I'll take notes for next time :)
@LLLKST LLLKST requested a review from waffle87 March 3, 2024 19:14
@LLLKST
Copy link
Contributor Author

LLLKST commented Mar 4, 2024

Once I've made the suggested changes should I mark the conversation as resolved or should I leave it to you after you've checked? Thanks!

@waffle87
Copy link
Member

waffle87 commented Mar 4, 2024

Once I've made the suggested changes should I mark the conversation as resolved or should I leave it to you after you've checked? Thanks!

If you have applied the suggested change, it is helpful to us for you to mark it as resolved. Thanks!

@waffle87 waffle87 requested a review from a team March 4, 2024 15:43
@LLLKST
Copy link
Contributor Author

LLLKST commented Mar 4, 2024

Once I've made the suggested changes should I mark the conversation as resolved or should I leave it to you after you've checked? Thanks!

If you have applied the suggested change, it is helpful to us for you to mark it as resolved. Thanks!

Now I know. Thank you very much!

@LLLKST LLLKST changed the title PetruziaMini Add PetruziaMini Mar 8, 2024
@LLLKST LLLKST changed the title Add PetruziaMini Add the PetruziaMini Handwired Keyboard Mar 8, 2024
@waffle87 waffle87 merged commit 6788a5e into qmk:master Mar 12, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
* Uploading the PetruziaMini

My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now

* 36 key hhbk inspired kb

* Required changes done

I compiled it locally and works

* Last changes requested

Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste

* Fixed imegur link

* Ops, i've lost this. Here it comes

Thanks for helping! I'll take notes for next time :)
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
* Uploading the PetruziaMini

My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now

* 36 key hhbk inspired kb

* Required changes done

I compiled it locally and works

* Last changes requested

Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste

* Fixed imegur link

* Ops, i've lost this. Here it comes

Thanks for helping! I'll take notes for next time :)
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
* Uploading the PetruziaMini

My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now

* 36 key hhbk inspired kb

* Required changes done

I compiled it locally and works

* Last changes requested

Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste

* Fixed imegur link

* Ops, i've lost this. Here it comes

Thanks for helping! I'll take notes for next time :)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* Uploading the PetruziaMini

My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now

* 36 key hhbk inspired kb

* Required changes done

I compiled it locally and works

* Last changes requested

Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste

* Fixed imegur link

* Ops, i've lost this. Here it comes

Thanks for helping! I'll take notes for next time :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants