Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure qmk generate-compilation-database copies to userspace as well. #23129

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Ensure qmk generate-compilation-database copies to userspace as well. #23129

merged 1 commit into from
Feb 22, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 22, 2024

Description

As per title. Bug reported on Discord.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Feb 22, 2024
@tzarc tzarc requested a review from a team February 22, 2024 11:19
@github-actions github-actions bot added python cli qmk cli command labels Feb 22, 2024
@burkfers
Copy link
Contributor

I tested this and it works exactly as expected.
For good measure, I compared the output compile_commands.json both in the root repo and in the userspace between generate-compilation-database and --compiledb with this fix and they're identical.

Thank you, tzarc!

@zvecr zvecr merged commit 56802f5 into qmk:develop Feb 22, 2024
4 of 5 checks passed
@tzarc tzarc deleted the cli/fixup-g-c-d-userspace branch February 24, 2024 03:00
peepeetee pushed a commit to peepeetee/qmk_firmware that referenced this pull request Mar 12, 2024
@tzarc @peepeetee
Ensure qmk generate-compilation-database copies to userspace as wel…
0679861 
…l. (qmk#23129)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@tzarc @nuess0r
Ensure qmk generate-compilation-database copies to userspace as wel…
7fad4fc 
…l. (qmk#23129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @burkfers @zvecr