Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add keyboard] Bartlesplit #23114

Merged
merged 24 commits into from
Mar 29, 2024
Merged

[Add keyboard] Bartlesplit #23114

merged 24 commits into from
Mar 29, 2024

Conversation

Kyrremann
Copy link
Contributor

Description

I've made a new keyboard that I'd like to add to the collection.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Feb 19, 2024
View reviewed changes
keyboards/minimon/bartlesplit/config.h Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/config.h Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/config.h Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/info.json Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/readme.md Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/readme.md Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/rules.mk Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/info.json Outdated Show resolved Hide resolved
Kyrremann and others added 3 commits February 19, 2024 21:43
@Kyrremann @waffle87
qr: removed unnecessary code
eb93b0c 
No need to specify default values, and remove some old mech lock support.

Co-authored-by: jack <[email protected]>
@Kyrremann
doc: moved image to Imgur
fd57a3d
@Kyrremann
fix: maintainer is defined in the minimon directory
96463c7
@waffle87 waffle87 requested a review from a team February 19, 2024 21:35
zvecr
zvecr requested changes Feb 19, 2024
View reviewed changes
keyboards/minimon/bartlesplit/info.json Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/matrix.c Outdated Show resolved Hide resolved
keyboards/minimon/bartlesplit/matrix.c Outdated Show resolved Hide resolved
@Kyrremann
Copy link
Contributor Author

@zvecr hi, got some time the coming week to take a look and maybe approve this PR?

@drashna drashna merged commit e44cbf7 into qmk:master Mar 29, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@Kyrremann @waffle87
@zvecr @drashna
[Keyboard] Bartlesplit (qmk#23114)
69af6f9 
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@Kyrremann @waffle87
@zvecr @drashna @girtsf
[Keyboard] Bartlesplit (qmk#23114)
8f6818d 
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@Kyrremann @waffle87
@zvecr @drashna @whoisjordangarcia
[Keyboard] Bartlesplit (qmk#23114)
0c2ce26 
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Kyrremann @waffle87
@zvecr @drashna @nuess0r
[Keyboard] Bartlesplit (qmk#23114)
0a9a162 
Co-authored-by: jack <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kyrremann @drashna @zvecr @waffle87