Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS Detection - Entire file should not be wrapped with ifdef #23108

Merged
merged 1 commit into from
Feb 19, 2024
Merged

OS Detection - Entire file should not be wrapped with ifdef #23108

merged 1 commit into from
Feb 19, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 19, 2024 •
edited
Loading

Description

Also removes unused typedef, and slightly aligns define locations.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 19, 2024
@zvecr zvecr merged commit 9f95577 into develop Feb 19, 2024
3 of 4 checks passed
@zvecr zvecr deleted the os_detect_tidy branch February 19, 2024 15:37
fpb pushed a commit to fpb/qmk_firmware that referenced this pull request Feb 19, 2024
@zvecr @fpb
OS Detection - Entire file should not be wrapped with ifdef (qmk#23108)
f9feeb9
fpb added a commit to fpb/qmk_firmware that referenced this pull request Feb 20, 2024
@fpb
Revert "OS Detection - Entire file should not be wrapped with ifdef (q…
f05b1b3 
…mk#23108)"

This reverts commit f9feeb9.
Kavakuo pushed a commit to Kavakuo/qmk_firmware_k1pro that referenced this pull request Jul 14, 2024
@zvecr @Kavakuo
OS Detection - Entire file should not be wrapped with ifdef (qmk#23108)
40dad70 
(cherry picked from commit 9f95577)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
OS Detection - Entire file should not be wrapped with ifdef (qmk#23108)
b5d9774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark