Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Keyboard] Add the Compensator #23103

Merged
merged 15 commits into from
Feb 21, 2024
Merged

[Add Keyboard] Add the Compensator #23103

merged 15 commits into from
Feb 21, 2024

Conversation

Lrfoster03
Copy link
Contributor

Added support for the Compensator Keyboard, seen here

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 18, 2024
keyboards/compensator/matrix_diagram.md Outdated Show resolved Hide resolved
keyboards/compensator/matrix_diagram.md Outdated Show resolved Hide resolved
keyboards/compensator/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/compensator/info.json Outdated Show resolved Hide resolved
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That or move the macro to compensator.c/h

keyboards/compensator/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/compensator/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@Lrfoster03
Copy link
Contributor Author

Initially, I wanted to leave the layers for the user to customize themselves, but I should've mentioned this. I believe this change will be better for the end-user anyway.

@waffle87 waffle87 merged commit 4e04da3 into qmk:master Feb 21, 2024
3 checks passed
peepeetee pushed a commit to peepeetee/qmk_firmware that referenced this pull request Mar 12, 2024
* Pushed up compensator start

* Addressed Firmware Changes

* Fixed some keybind issues

* Updated readMe

* Added keymap

* Adjustments for PR

* adjusted on-state

* Applied sugguested changes

* Addressed PR changes

* Addressed macro comments

* Addressed layer comments
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* Pushed up compensator start

* Addressed Firmware Changes

* Fixed some keybind issues

* Updated readMe

* Added keymap

* Adjustments for PR

* adjusted on-state

* Applied sugguested changes

* Addressed PR changes

* Addressed macro comments

* Addressed layer comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants