-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add Keyboard] Add the Compensator #23103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
labels
Feb 18, 2024
fauxpark
requested changes
Feb 18, 2024
zvecr
requested changes
Feb 18, 2024
drashna
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That or move the macro to compensator.c/h
waffle87
reviewed
Feb 19, 2024
Initially, I wanted to leave the layers for the user to customize themselves, but I should've mentioned this. I believe this change will be better for the end-user anyway. |
waffle87
approved these changes
Feb 21, 2024
fauxpark
approved these changes
Feb 21, 2024
7 tasks
7 tasks
peepeetee
pushed a commit
to peepeetee/qmk_firmware
that referenced
this pull request
Mar 12, 2024
* Pushed up compensator start * Addressed Firmware Changes * Fixed some keybind issues * Updated readMe * Added keymap * Adjustments for PR * adjusted on-state * Applied sugguested changes * Addressed PR changes * Addressed macro comments * Addressed layer comments
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
* Pushed up compensator start * Addressed Firmware Changes * Fixed some keybind issues * Updated readMe * Added keymap * Adjustments for PR * adjusted on-state * Applied sugguested changes * Addressed PR changes * Addressed macro comments * Addressed layer comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Compensator Keyboard, seen here
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist