Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GPIO macro usages in core #23093

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Update GPIO macro usages in core #23093

merged 3 commits into from
Feb 18, 2024

Conversation

fauxpark
Copy link
Member

Description

Part 2 of #23085.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 16, 2024 13:38
KarlK90
KarlK90 approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build failures due to oversize.

@fauxpark
Copy link
Member Author

Unrelated; KBD67 has been fixed already and Helix is still failing on develop.

tzarc
tzarc approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random selection of 100 different boards in the repo show matching SHA1's.

@tzarc tzarc merged commit 2d1aed7 into qmk:develop Feb 18, 2024
4 of 5 checks passed
@fauxpark fauxpark deleted the gpio-macros-update-core branch February 18, 2024 07:06
atechofficials added a commit to atechofficials/qmk_firmware that referenced this pull request Jul 10, 2024
@atechofficials @fauxpark
Update keyboards/protokeeb/rev1/rev1.c
739ff79 
Renaming Arduino-style GPIO pin functions (qmk#23085, qmk#23093)

Co-authored-by: Ryan <[email protected]>
atechofficials added a commit to atechofficials/qmk_firmware that referenced this pull request Jul 13, 2024
@atechofficials
Changed readPin function to gpio_read_pin function in rev1.c file bec…
cb54da6 
…ause of core change: Renaming Arduino-style GPIO pin functions qmk#23085, qmk#23093
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Update GPIO macro usages in core (qmk#23093)
ee99e68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @tzarc @KarlK90