Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Tomak PCB support #22881

Closed
wants to merge 5 commits into from
Closed

[Keyboard] Tomak PCB support #22881

wants to merge 5 commits into from

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Jan 10, 2024

Tomak_HS PCB for SIRIND TOMAK

Description

Ergonomics Split PCB powered by RP2040.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add Toamk_HS
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 10, 2024
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a readme.md file, please see the template in the PR checklist.

@zvecr
Copy link
Member

zvecr commented Jan 10, 2024

You currently have 2 vendor drivers assigned to the same PIO block. Has this actually been tested on hardware?

Add readme.md
@eerraa
Copy link
Contributor Author

eerraa commented Jan 10, 2024

You are missing a readme.md file, please see the template in the PR checklist.

Thank you sir, Added.

@eerraa
Copy link
Contributor Author

eerraa commented Jan 10, 2024

You currently have 2 vendor drivers assigned to the same PIO block. Has this actually been tested on hardware?
@zvecr
Yes, this has actually been tested on hardware.
The firmware appears to work fine on the current hardware.
Would it be better for me to define "SERIAL_PIO_USE_PIO1"?

@zvecr
Copy link
Member

zvecr commented Jan 10, 2024

Would it be better for me to define "SERIAL_PIO_USE_PIO1"?

Ignore me, I seem to have miss-remembered.

#22615 (comment)

The WS2812 driver can fit in the same PIO as either PS2 or SERIAL.

keyboards/era/sirind/tomak/config.h Outdated Show resolved Hide resolved
keyboards/era/sirind/tomak/config.h Outdated Show resolved Hide resolved
keyboards/era/sirind/tomak/rules.mk Outdated Show resolved Hide resolved
eerraa and others added 2 commits January 10, 2024 23:12
Move sirind/tomak to sirind/toamk_hs
& Run qmk format-json
keyboards/era/sirind/tomak_hs/config.h Outdated Show resolved Hide resolved
keyboards/era/sirind/tomak_hs/info.json Outdated Show resolved Hide resolved
keyboards/era/sirind/tomak_hs/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/era/sirind/tomak_hs/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Move animations & Run qmk format-json
@eerraa eerraa requested a review from drashna January 13, 2024 10:16
@eerraa eerraa closed this Jan 21, 2024
@eerraa eerraa deleted the tomak branch January 23, 2024 19:04
@waffle87 waffle87 mentioned this pull request Apr 18, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants