Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: group kbdfans keyboards #22764

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Refactor: group kbdfans keyboards #22764

merged 1 commit into from
Feb 19, 2024

Conversation

filterpaper
Copy link
Contributor

Description

Move two kbdfans keyboard into kbdfans folder

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes labels Dec 27, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 11, 2024
@filterpaper
Copy link
Contributor Author

Still pending approvals

@filterpaper
Refactor: group kbdfans keyboards
1a8d79d 
Move two kbdfans keyboard into kbdfans folder
@fauxpark fauxpark requested a review from a team February 11, 2024 04:49
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Feb 12, 2024
@zvecr zvecr merged commit bc7d1cc into qmk:develop Feb 19, 2024
3 checks passed
@filterpaper filterpaper deleted the refactor-kbdfans branch February 19, 2024 11:18
fpb pushed a commit to fpb/qmk_firmware that referenced this pull request Feb 19, 2024
@filterpaper @fpb
Refactor: group kbdfans keyboards (qmk#22764)
01b1274 
Move two kbdfans keyboard into kbdfans folder
fpb added a commit to fpb/qmk_firmware that referenced this pull request Feb 20, 2024
@fpb
Revert "Refactor: group kbdfans keyboards (qmk#22764)"
2900d2c 
This reverts commit 01b1274.
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@filterpaper @nuess0r
Refactor: group kbdfans keyboards (qmk#22764)
837c721 
Move two kbdfans keyboard into kbdfans folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @fauxpark @zvecr