Updating NCC1701KB and adding via support #22721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RETRY of PR qmk#22705 After a strange problem with the develop branch. It was causing a HUGE amount of conflict errors. I was told to just make a new PR. This contains ALL of the suggestions and commits from the reviewers of the original PR, so there shouldn't be any changes.
github-actions
bot
added
keyboard
keymap
via
|
@fauxpark This should do it, right? |
fauxpark
approved these changes
Dec 20, 2023
zvecr
changed the title
drashna
approved these changes
Dec 20, 2023
itsjonny96
pushed a commit
to itsjonny96/qmk_firmware
that referenced
this pull request
Jan 7, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 17, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 19, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RETRY of PR #22705 After a strange problem with the develop branch. It was causing a HUGE amount of conflict errors. I was told to just make a new PR. This contains ALL of the suggestions and commits from the reviewers of the original PR, so there shouldn't be any changes.
Description
As I said, this is a redo of #22705 so it already had over 20 committed suggestions from reviewers.
But since this needed to be in the dev branch, while trying to change it created a ton of conflict problems.
So, as suggested by @fauxpark I remade the PR because it would be easier.
Just cleaned up an old keyboard that needed updating and also added a keymap for Via support
Types of Changes
Issues Fixed or Closed by This PR
Checklist