Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KM113 keyboard #22669

Merged
merged 25 commits into from
Mar 13, 2024
Merged

Added KM113 keyboard #22669

merged 25 commits into from
Mar 13, 2024

Conversation

yelishang
Copy link
Contributor

@yelishang yelishang commented Dec 15, 2023 •
edited
Loading

Description

Added KM113 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 15, 2023
waffle87
waffle87 requested changes Dec 16, 2023
View reviewed changes
keyboards/jidohun/qmk113/config.h Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/info.json Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/info.json Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/rules.mk Outdated Show resolved Hide resolved
@yelishang @waffle87
更新 config.h
08d28d5 
Co-authored-by: jack <[email protected]>
drashna
drashna requested changes Dec 23, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The board (probably) should be renamed, as this isn't a board released by QMK itself.

https://qmk.fm/powered/

keyboards/jidohun/qmk113/config.h Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/config.h Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/info.json Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/rules.mk Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/jidohun/qmk113/keymaps/via/keymap.c Outdated Show resolved Hide resolved
yelishang and others added 10 commits December 24, 2023 09:16
@yelishang @drashna
更新 config.h
fe58e57 
Co-authored-by: Drashna Jaelre <[email protected]>
@yelishang @drashna
更新 config.h
d03ba38 
Co-authored-by: Drashna Jaelre <[email protected]>
@yelishang @drashna
更新 keymap.c
20511ca 
Co-authored-by: Drashna Jaelre <[email protected]>
@yelishang @drashna
更新 info.json
2af3e04 
Co-authored-by: Drashna Jaelre <[email protected]>
@yelishang
Merge branch 'wind' of github.com:yelishang/qmk_firmware into wind
ece7167 
# Conflicts:
#	keyboards/jidohun/qmk113/config.h
#	keyboards/jidohun/qmk113/info.json
#	keyboards/jidohun/qmk113/keymaps/via/keymap.c
#	keyboards/jidohun/qmk113/rules.mk
@yelishang
Changed the name of QMK113 to KM113
840998b
@yelishang
Merge branch 'master' into wind
5947748
@yelishang
Merge branch 'master' into wind
32cec5c
@yelishang
Merge branch 'master' into wind
1832d52
@yelishang
update rules.mk
b172f8e
@yelishang yelishang changed the title Added QMK113 keyboard Added MK113 keyboard Jan 8, 2024
@yelishang yelishang changed the title Added MK113 keyboard Added KM113 keyboard Jan 9, 2024
@yelishang @itarze
更新 info.json
9ee0fbf 
Co-authored-by: Joy Lee <[email protected]>
@drashna drashna requested a review from a team January 14, 2024 05:23
zvecr
zvecr requested changes Jan 17, 2024
View reviewed changes
keyboards/jidohun/km113/info.json Outdated Show resolved Hide resolved
@yelishang @zvecr
更新 info.json
909963b 
Co-authored-by: Joel Challis <[email protected]>
fauxpark
fauxpark requested changes Feb 6, 2024
View reviewed changes
keyboards/jidohun/km113/info.json Outdated Show resolved Hide resolved
@yelishang @fauxpark
更新 info.json
f551ed6 
Co-authored-by: Ryan <[email protected]>
zvecr
zvecr requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/jidohun/km113/rules.mk was incorrectly deleted in 5dc6364 and the keyboard does not actually compile.

@yelishang
Copy link
Contributor Author

Can merge?

@zvecr zvecr merged commit 49596b0 into qmk:master Mar 13, 2024
3 checks passed
@yelishang yelishang mentioned this pull request Mar 19, 2024
Merged
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@yelishang
Add KM113 keyboard (qmk#22669)
fdde13a
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@yelishang @girtsf
Add KM113 keyboard (qmk#22669)
e0730e3
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@yelishang @whoisjordangarcia
Add KM113 keyboard (qmk#22669)
532d4ea
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@yelishang @nuess0r
Add KM113 keyboard (qmk#22669)
e7f8a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itarze itarze itarze left review comments

@waffle87 waffle87 waffle87 requested changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yelishang @drashna @fauxpark @zvecr @waffle87 @itarze