Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solid reactive: improve fading effect #22656

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Solid reactive: improve fading effect #22656

merged 1 commit into from
Jan 9, 2024

Conversation

filterpaper
Copy link
Contributor

Description

Fading effect is smoother with scale8 function

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper
Solid reactive: improve fading effect
301c9c1 
Fading effect is smoother with scale8 function
@github-actions github-actions bot added the core label Dec 14, 2023
@tzarc tzarc merged commit f39386a into qmk:develop Jan 9, 2024
4 checks passed
@filterpaper filterpaper deleted the solid-reactive-fade branch January 9, 2024 11:35
mklein994 pushed a commit to mklein994/qmk_firmware that referenced this pull request Apr 7, 2024
@filterpaper @mklein994
Solid reactive: improve fading effect (qmk#22656)
f3b8402 
(cherry picked from commit f39386a)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@filterpaper @nuess0r
Solid reactive: improve fading effect (qmk#22656)
38a4788
mklein994 pushed a commit to mklein994/qmk_firmware that referenced this pull request Nov 21, 2024
@filterpaper @mklein994
Solid reactive: improve fading effect (qmk#22656)
b812138 
(cherry picked from commit f39386a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @tzarc