Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Pumpkin Pad to Pumkinpad #22651

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Rename Pumpkin Pad to Pumkinpad #22651

merged 3 commits into from
Dec 13, 2023

Conversation

zykrah
Copy link
Contributor

@zykrah zykrah commented Dec 13, 2023

Description

As in the title, requested by Laser Ninja themselves.

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 13, 2023
fauxpark
fauxpark requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alias will need to be added to data/mappings/keyboard_aliases.hjson.

@fauxpark fauxpark requested a review from a team December 13, 2023 05:12
@zykrah
Copy link
Contributor Author

zykrah commented Dec 13, 2023

Alias will need to be added to data/mappings/keyboard_aliases.hjson.

What kind of alias? An alias to link laser_ninja/pumkinpad to pumkinpad or to link the old name: laser_ninja/pumkinpad to laser_ninja/pumkin_pad?

@fauxpark
Copy link
Member

The old FQN to the new one. Have a look at that file, you should see what I mean.

@zykrah zykrah mentioned this pull request Dec 13, 2023
Merged
7 tasks
@github-actions github-actions bot added the dd Data Driven Changes label Dec 13, 2023
@zykrah zykrah requested a review from fauxpark December 13, 2023 05:34
@zykrah zykrah requested a review from fauxpark December 13, 2023 07:18
@zvecr zvecr merged commit 05d2b7e into qmk:develop Dec 13, 2023
2 of 3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@zykrah @itsjonny96
Rename Pumpkin Pad to Pumkinpad (qmk#22651)
29a67d4
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zykrah @mechlovin
Rename Pumpkin Pad to Pumkinpad (qmk#22651)
ed9560b
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zykrah @mechlovin
Rename Pumpkin Pad to Pumkinpad (qmk#22651)
ca59a7f
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zykrah @nuess0r
Rename Pumpkin Pad to Pumkinpad (qmk#22651)
c872318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zykrah @fauxpark @zvecr