-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyboard tg67 with rgb #22592
Merged
Merged
add keyboard tg67 with rgb #22592
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
448d7f8
add keyboard tg67
eedd3f5
Merge branch 'master' into tg67
LXF-YZP 0d62a8d
add rgblight config
0753586
Merge branch 'tg67' of github.com:LXF-YZP/qmk_firmware into tg67
966f6c0
Merge branch 'master' into tg67
LXF-YZP f90326c
Merge branch 'master' into tg67
LXF-YZP 1520a3f
move pwm_pal_mode
e954947
Merge branch 'master' into tg67
LXF-YZP de91acc
Merge branch 'master' into tg67
LXF-YZP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* Copyright 2022 LXF-YZP(yuezp) | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#define WS2812_PWM_DRIVER PWMD1 | ||
#define WS2812_PWM_CHANNEL 3 | ||
#define WS2812_PWM_PAL_MODE 2 | ||
#define WS2812_PWM_COMPLEMENTARY_OUTPUT | ||
#define WS2812_DMA_STREAM STM32_DMA1_STREAM5 | ||
#define WS2812_DMA_CHANNEL 5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* Copyright 2022 LXF-YZP(yuezp) | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
#pragma once | ||
|
||
#define HAL_USE_PWM TRUE | ||
|
||
#include_next <halconf.h> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
{ | ||
"manufacturer": "TG", | ||
"keyboard_name": "TG67", | ||
"maintainer": "TG", | ||
"bootloader": "stm32-dfu", | ||
"diode_direction": "COL2ROW", | ||
"features": { | ||
"bootmagic": true, | ||
"extrakey": true, | ||
"mousekey": true, | ||
"nkro": true | ||
}, | ||
"matrix_pins": { | ||
"cols": ["A7", "B0", "B1", "B2", "B10", "B11", "B12", "B14", "A9", "A10", "A8", "B6", "B7", "B5", "B4"], | ||
"rows": ["A1", "A2", "A3", "A4", "A5"] | ||
}, | ||
"processor": "STM32F072", | ||
"rgblight": { | ||
"animations": { | ||
"alternating": true, | ||
"breathing": true, | ||
"christmas": true, | ||
"knight": true, | ||
"rainbow_mood": true, | ||
"rainbow_swirl": true, | ||
"rgb_test": true, | ||
"snake": true, | ||
"static_gradient": true, | ||
"twinkle": true | ||
}, | ||
"brightness_steps": 10, | ||
"led_count": 69, | ||
"saturation_steps": 8 | ||
}, | ||
"url": "", | ||
"usb": { | ||
"device_version": "0.0.1", | ||
"pid": "0x6667", | ||
"vid": "0x4552" | ||
}, | ||
"ws2812": { | ||
"driver": "pwm", | ||
"pin": "B15" | ||
}, | ||
"community_layouts": ["65_ansi_blocker"], | ||
"layouts": { | ||
"LAYOUT_65_ansi_blocker": { | ||
"layout": [ | ||
{"label": "ESC", "matrix": [0, 0], "x": 0, "y": 0}, | ||
{"label": "!", "matrix": [0, 1], "x": 1, "y": 0}, | ||
{"label": "@", "matrix": [0, 2], "x": 2, "y": 0}, | ||
{"label": "#", "matrix": [0, 3], "x": 3, "y": 0}, | ||
{"label": "$", "matrix": [0, 4], "x": 4, "y": 0}, | ||
{"label": "%", "matrix": [0, 5], "x": 5, "y": 0}, | ||
{"label": "^", "matrix": [0, 6], "x": 6, "y": 0}, | ||
{"label": "&", "matrix": [0, 7], "x": 7, "y": 0}, | ||
{"label": "*", "matrix": [0, 8], "x": 8, "y": 0}, | ||
{"label": "(", "matrix": [0, 9], "x": 9, "y": 0}, | ||
{"label": ")", "matrix": [0, 10], "x": 10, "y": 0}, | ||
{"label": "_", "matrix": [0, 11], "x": 11, "y": 0}, | ||
{"label": "+", "matrix": [0, 12], "x": 12, "y": 0}, | ||
{"label": "Backspace", "matrix": [0, 13], "x": 13, "y": 0, "w": 2}, | ||
{"label": "Delete", "matrix": [0, 14], "x": 15, "y": 0}, | ||
|
||
{"label": "Tab", "matrix": [1, 0], "x": 0, "y": 1, "w": 1.5}, | ||
{"label": "Q", "matrix": [1, 1], "x": 1.5, "y": 1}, | ||
{"label": "W", "matrix": [1, 2], "x": 2.5, "y": 1}, | ||
{"label": "E", "matrix": [1, 3], "x": 3.5, "y": 1}, | ||
{"label": "R", "matrix": [1, 4], "x": 4.5, "y": 1}, | ||
{"label": "T", "matrix": [1, 5], "x": 5.5, "y": 1}, | ||
{"label": "Y", "matrix": [1, 6], "x": 6.5, "y": 1}, | ||
{"label": "U", "matrix": [1, 7], "x": 7.5, "y": 1}, | ||
{"label": "I", "matrix": [1, 8], "x": 8.5, "y": 1}, | ||
{"label": "O", "matrix": [1, 9], "x": 9.5, "y": 1}, | ||
{"label": "P", "matrix": [1, 10], "x": 10.5, "y": 1}, | ||
{"label": "{", "matrix": [1, 11], "x": 11.5, "y": 1}, | ||
{"label": "}", "matrix": [1, 12], "x": 12.5, "y": 1}, | ||
{"label": "|", "matrix": [1, 13], "x": 13.5, "y": 1, "w": 1.5}, | ||
{"label": "Home", "matrix": [1, 14], "x": 15, "y": 1}, | ||
|
||
{"label": "Caps Lock", "matrix": [2, 0], "x": 0, "y": 2, "w": 1.75}, | ||
{"label": "A", "matrix": [2, 1], "x": 1.75, "y": 2}, | ||
{"label": "S", "matrix": [2, 2], "x": 2.75, "y": 2}, | ||
{"label": "D", "matrix": [2, 3], "x": 3.75, "y": 2}, | ||
{"label": "F", "matrix": [2, 4], "x": 4.75, "y": 2}, | ||
{"label": "G", "matrix": [2, 5], "x": 5.75, "y": 2}, | ||
{"label": "H", "matrix": [2, 6], "x": 6.75, "y": 2}, | ||
{"label": "J", "matrix": [2, 7], "x": 7.75, "y": 2}, | ||
{"label": "K", "matrix": [2, 8], "x": 8.75, "y": 2}, | ||
{"label": "L", "matrix": [2, 9], "x": 9.75, "y": 2}, | ||
{"label": ":", "matrix": [2, 10], "x": 10.75, "y": 2}, | ||
{"label": "k90", "matrix": [2, 11], "x": 11.75, "y": 2}, | ||
{"label": "Enter", "matrix": [2, 13], "x": 12.75, "y": 2, "w": 2.25}, | ||
{"label": "PgUp", "matrix": [2, 14], "x": 15, "y": 2}, | ||
|
||
{"label": "Shift", "matrix": [3, 0], "x": 0, "y": 3, "w": 2.25}, | ||
{"label": "Z", "matrix": [3, 1], "x": 2.25, "y": 3}, | ||
{"label": "X", "matrix": [3, 2], "x": 3.25, "y": 3}, | ||
{"label": "C", "matrix": [3, 3], "x": 4.25, "y": 3}, | ||
{"label": "V", "matrix": [3, 4], "x": 5.25, "y": 3}, | ||
{"label": "B", "matrix": [3, 5], "x": 6.25, "y": 3}, | ||
{"label": "N", "matrix": [3, 6], "x": 7.25, "y": 3}, | ||
{"label": "M", "matrix": [3, 7], "x": 8.25, "y": 3}, | ||
{"label": "<", "matrix": [3, 8], "x": 9.25, "y": 3}, | ||
{"label": ">", "matrix": [3, 9], "x": 10.25, "y": 3}, | ||
{"label": "?", "matrix": [3, 10], "x": 11.25, "y": 3}, | ||
{"label": "Shift", "matrix": [3, 11], "x": 12.25, "y": 3, "w": 1.75}, | ||
{"label": "Up", "matrix": [3, 13], "x": 14, "y": 3}, | ||
{"label": "PgDn", "matrix": [3, 14], "x": 15, "y": 3}, | ||
|
||
{"label": "Ctrl", "matrix": [4, 0], "x": 0, "y": 4, "w": 1.25}, | ||
{"label": "Win", "matrix": [4, 1], "x": 1.25, "y": 4, "w": 1.25}, | ||
{"label": "Alt", "matrix": [4, 2], "x": 2.5, "y": 4, "w": 1.25}, | ||
{"label": "Space", "matrix": [4, 6], "x": 3.75, "y": 4, "w": 6.25}, | ||
{"label": "K91", "matrix": [4, 9], "x": 10, "y": 4, "w": 1.25}, | ||
{"label": "K92", "matrix": [4, 10], "x": 11.25, "y": 4, "w": 1.25}, | ||
{"label": "Left", "matrix": [4, 12], "x": 13, "y": 4}, | ||
{"label": "Down", "matrix": [4, 13], "x": 14, "y": 4}, | ||
{"label": "Right", "matrix": [4, 14], "x": 15, "y": 4} | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* Copyright 2022 LXF-YZP(yuezp) | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#include QMK_KEYBOARD_H | ||
|
||
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
||
[0]=LAYOUT_65_ansi_blocker( | ||
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_HOME, | ||
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS, KC_END, | ||
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT, KC_PGUP, | ||
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, KC_UP, KC_PGDN, | ||
KC_LCTL, KC_LGUI, KC_LALT, KC_SPC, MO(1), KC_RCTL, KC_LEFT, KC_DOWN, KC_RGHT), | ||
|
||
[1]=LAYOUT_65_ansi_blocker( | ||
KC_GRV, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS) | ||
|
||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* Copyright 2022 LXF-YZP(yuezp) | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#include QMK_KEYBOARD_H | ||
|
||
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
||
[0]=LAYOUT_65_ansi_blocker( | ||
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_HOME, | ||
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS, KC_END, | ||
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT, KC_PGUP, | ||
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, KC_UP, KC_PGDN, | ||
KC_LCTL, KC_LGUI, KC_LALT, KC_SPC, MO(1), KC_RCTL, KC_LEFT, KC_DOWN, KC_RGHT), | ||
|
||
[1]=LAYOUT_65_ansi_blocker( | ||
KC_GRV, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, | ||
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS) | ||
|
||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
VIA_ENABLE = yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Matrix Diagram for Tg67 | ||
|
||
``` | ||
┌───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───┬───────┬───┐ | ||
│00 │01 │02 │03 │04 │05 │06 │07 │08 │09 │0A │0B │0C │0D │0E │ | ||
├───┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─────┼───┤ | ||
│10 │11 │12 │13 │14 │15 │16 │17 │18 │19 │1A │1B │1C │1D │1E │ | ||
├─────┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴┬──┴─────┼───┤ | ||
│20 │21 │22 │23 │24 │25 │26 │27 │28 │29 │2A │2B │2D │2E │ | ||
├────┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴─┬─┴────┬───┼───┤ | ||
│30 │31 │32 │33 │34 │35 │36 │37 │38 │39 │3A │3B │3C │3D │3E │ | ||
├────┼───┴┬──┴─┬─┴───┴───┴───┴───┴───┴──┬┴───┼───┴┬─┬───┼───┼───┤ | ||
│40 │41 │42 │46 │49 │4A │ │4C │4D │4E │ | ||
└────┴────┴────┴────────────────────────┴────┴────┘ └───┴───┴───┘ | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* Copyright 2022 LXF-YZP(yuezp) | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include_next <mcuconf.h> | ||
|
||
#undef STM32_PWM_USE_TIM1 | ||
#define STM32_PWM_USE_TIM1 TRUE | ||
|
||
#undef STM32_PWM_USE_ADVANCED | ||
#define STM32_PWM_USE_ADVANCED TRUE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# TG67 - PCB | ||
|
||
![tg67](https://imgur.com/Ut555KYh.jpg) | ||
|
||
A 67 layout pcb. | ||
|
||
* Keyboard Maintainer: https://github.com/LXF-YZP | ||
* Hardware Supported: tg67 PCB | ||
|
||
Make example for this keyboard (after setting up your build environment): | ||
|
||
make tg67:default | ||
|
||
Flashing example for this keyboard: | ||
|
||
make tg67:default:flash | ||
|
||
See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs). | ||
|
||
## Bootloader | ||
|
||
Enter the bootloader in 3 ways: | ||
|
||
* **Bootmagic reset**: Hold down the key at (0,0) in the matrix (usually the top left key or Escape) and plug in the keyboard | ||
* **Physical reset button**: Briefly press the button on the back of the PCB - some may have pads you must short instead | ||
* **Keycode in layout**: Press the key mapped to `QK_BOOT` if it is available |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# This file intentionally left blank |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you