Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Q8 #22578

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Update Q8 #22578

merged 5 commits into from
Dec 14, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Superseeds #21423, but this will only cover one board from each series update of PRs. Also enables Num Lock Indicator LED.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@adophoxia adophoxia changed the title Update Q9 Update Q8 Nov 30, 2023
@drashna drashna requested a review from a team December 5, 2023 04:17
fauxpark
fauxpark requested changes Dec 5, 2023
View reviewed changes
keyboards/keychron/q8/ansi_encoder/info.json Outdated Show resolved Hide resolved
keyboards/keychron/q8/iso/info.json Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 13, 2023 23:40
@waffle87 waffle87 merged commit f19fa98 into qmk:develop Dec 14, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@adophoxia @fauxpark @itsjonny96
[Keyboard] Update Keychron Q8 (qmk#22578)
e7ce9ba 
* Update Q8

* Run `qmk format-json` and remove `RGB_MATRIX_LED_COUNT`

* Update keyboards/keychron/q8/ansi_encoder/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/keychron/q8/iso/info.json

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@adophoxia @fauxpark @mechlovin
[Keyboard] Update Keychron Q8 (qmk#22578)
75c24fc 
* Update Q8

* Run `qmk format-json` and remove `RGB_MATRIX_LED_COUNT`

* Update keyboards/keychron/q8/ansi_encoder/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/keychron/q8/iso/info.json

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@adophoxia @fauxpark @mechlovin
[Keyboard] Update Keychron Q8 (qmk#22578)
e0792de 
* Update Q8

* Run `qmk format-json` and remove `RGB_MATRIX_LED_COUNT`

* Update keyboards/keychron/q8/ansi_encoder/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/keychron/q8/iso/info.json

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@adophoxia @fauxpark @nuess0r
[Keyboard] Update Keychron Q8 (qmk#22578)
f23e009 
* Update Q8

* Run `qmk format-json` and remove `RGB_MATRIX_LED_COUNT`

* Update keyboards/keychron/q8/ansi_encoder/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/keychron/q8/iso/info.json

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adophoxia @drashna @fauxpark @waffle87